Non-SFI NaCl: Batch-open resource files

components/nacl/common/nacl_types.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 #define COMPONENTS_NACL_COMMON_NACL_TYPES_H_
 
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/shared_memory.h"
 #include "base/process/process_handle.h"
 #include "build/build_config.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_platform_file.h"
 
 #if defined(OS_POSIX)
@@ skipping 36 matching lines @@
   // (not user-provided).
   kPNaClTranslatorProcessType,
   kNumNaClProcessTypes
 };
 
 // Parameters sent to the NaCl process when we start it.
 struct NaClStartParams {
   NaClStartParams();
   ~NaClStartParams();
 
+  struct ResourceFileInfo {
+    ResourceFileInfo();
+    ResourceFileInfo(IPC::PlatformFileForTransit file,
+                     const base::FilePath& file_path_metadata,
+                     const std::string& file_key);
+    ~ResourceFileInfo();
+
+    IPC::PlatformFileForTransit file;
+    base::FilePath file_path_metadata;

[teravest, 2014/11/10 20:36:11]

Documenting the intended use for file_path_metadata would be good here,
especially because metadata sounds mysterious. Shouldn't file_path be sufficient
for the name here anyway?

[Yusuke Sato, 2014/11/11 00:58:35]

Done.

I think I used the suffix to make the variable name consistent with the ones in
your next token validation patch, but just |file_path| is also fine. Changed.

+    std::string file_key;
+  };
+
   IPC::PlatformFileForTransit nexe_file;
   uint64_t nexe_token_lo;
   uint64_t nexe_token_hi;
 
+  std::vector<ResourceFileInfo> resource_files;
   std::vector<FileDescriptor> handles;
   FileDescriptor debug_stub_server_bound_socket;
 
   bool validation_cache_enabled;
   std::string validation_cache_key;
   // Chrome version string. Sending the version string over IPC avoids linkage
   // issues in cases where NaCl is not compiled into the main Chromium
   // executable or DLL.
   std::string version;
 
   bool enable_debug_stub;
   bool enable_ipc_proxy;
 
   NaClAppProcessType process_type;
 
   // For NaCl <-> renderer crash information reporting.
   base::SharedMemoryHandle crash_info_shmem_handle;
 
   // NOTE: Any new fields added here must also be added to the IPC
   // serialization in nacl_messages.h and (for POD fields) the constructor
   // in nacl_types.cc.
 };
 
 // Parameters sent to the browser process to have it launch a NaCl process.
 //
 // If you change this, you will also need to update the IPC serialization in
 // nacl_host_messages.h.
 struct NaClLaunchParams {
+  struct ResourceFileInfo;
   NaClLaunchParams();
-  NaClLaunchParams(const std::string& manifest_url,
-                   const IPC::PlatformFileForTransit& nexe_file,
-                   uint64_t nexe_token_lo,
-                   uint64_t nexe_token_hi,
-                   int render_view_id,
-                   uint32 permission_bits,
-                   bool uses_nonsfi_mode,
-                   NaClAppProcessType process_type);
+  NaClLaunchParams(
+      const std::string& manifest_url,
+      const IPC::PlatformFileForTransit& nexe_file,
+      uint64_t nexe_token_lo,
+      uint64_t nexe_token_hi,
+      const std::vector<ResourceFileInfo>& resource_files,
+      int render_view_id,
+      uint32 permission_bits,
+      bool uses_nonsfi_mode,
+      NaClAppProcessType process_type);
   ~NaClLaunchParams();
 
+  struct ResourceFileInfo {
+    ResourceFileInfo();
+    ResourceFileInfo(IPC::PlatformFileForTransit file,
+                     uint64_t file_token_lo,
+                     uint64_t file_token_hi,
+                     const std::string& file_key);
+    ~ResourceFileInfo();
+
+    IPC::PlatformFileForTransit file;
+    uint64_t file_token_lo;
+    uint64_t file_token_hi;
+    std::string file_key;

[teravest, 2014/11/10 20:36:11]

I think it's worth adding a comment that file_key corresponds to a key in the
"files" section of the NMF file.

[Yusuke Sato, 2014/11/11 00:58:35]

Good idea. Done.

+  };
+
   std::string manifest_url;
   // On Windows, the HANDLE passed here is valid in the renderer's context.
   // It's the responsibility of the browser to duplicate this handle properly
   // for passing it to the plugin.
   IPC::PlatformFileForTransit nexe_file;
   uint64_t nexe_token_lo;
   uint64_t nexe_token_hi;
+  std::vector<ResourceFileInfo> resource_files_info;
 
   int render_view_id;
   uint32 permission_bits;
   bool uses_nonsfi_mode;
 
   NaClAppProcessType process_type;
 };
 
 struct NaClLaunchResult {
   NaClLaunchResult();
@@ skipping 20 matching lines @@
   // For plugin <-> renderer ManifestService communication.
   IPC::ChannelHandle manifest_service_ipc_channel_handle;
 
   base::ProcessId plugin_pid;
   int plugin_child_id;
 
   // For NaCl <-> renderer crash information reporting.
   base::SharedMemoryHandle crash_info_shmem_handle;
 };
 
+struct NaClOpenExecutableResult {
+  struct FileInfo;
+  NaClOpenExecutableResult();
+  NaClOpenExecutableResult(const FileInfo& file_info,
+                           const std::vector<FileInfo>& resource_files_info);
+  ~NaClOpenExecutableResult();
+
+  struct FileInfo {
+    FileInfo();
+    FileInfo(IPC::PlatformFileForTransit file,
+             uint64_t file_token_lo,
+             uint64_t file_token_hi);
+    ~FileInfo();
+
+    IPC::PlatformFileForTransit file;
+    uint64_t file_token_lo;
+    uint64_t file_token_hi;
+  };
+
+  FileInfo file_info;
+  std::vector<FileInfo> resource_files_info;
+};
+
 }  // namespace nacl
 
 #endif  // COMPONENTS_NACL_COMMON_NACL_TYPES_H_