Non-SFI NaCl: Batch-open resource files

components/nacl/browser/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/browser/nacl_process_host.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 213 matching lines @@
   handles_for_sel_ldr->push_back(channel);
 #endif
   return true;
 }
 
 }  // namespace
 
 unsigned NaClProcessHost::keepalive_throttle_interval_milliseconds_ =
     ppapi::kKeepaliveThrottleIntervalDefaultMilliseconds;
 
-NaClProcessHost::NaClProcessHost(const GURL& manifest_url,
-                                 base::File nexe_file,
-                                 const NaClFileToken& nexe_token,
-                                 ppapi::PpapiPermissions permissions,
-                                 int render_view_id,
-                                 uint32 permission_bits,
-                                 bool uses_nonsfi_mode,
-                                 bool off_the_record,
-                                 NaClAppProcessType process_type,
-                                 const base::FilePath& profile_directory)
+NaClProcessHost::ResourceFileInfo::ResourceFileInfo()
+    : file_token_() {

[teravest, 2014/11/10 20:36:11]

Is this initializer necessary?

[Yusuke Sato, 2014/11/11 00:58:35]

Since the struct does not have a constructor, I wanted to initialize it with
zeros.

+}
+
+NaClProcessHost::ResourceFileInfo::ResourceFileInfo(
+    base::File file,
+    const NaClFileToken& file_token,
+    const std::string& file_key)
+    : file_(file.Pass()),
+      file_token_(file_token),
+      file_key_(file_key) {
+}
+
+NaClProcessHost::ResourceFileInfo::~ResourceFileInfo() {
+}
+
+NaClProcessHost::ResourceFileInfo::ResourceFileInfo(RValue other)
+    : file_(other.object->file_.Pass()),
+      file_token_(other.object->file_token()),
+      file_key_(other.object->file_key()) {
+}
+
+NaClProcessHost::ResourceFileInfo&
+NaClProcessHost::ResourceFileInfo::operator=(RValue other) {
+  if (this != other.object) {
+    file_ = other.object->file_.Pass();
+    file_token_ = other.object->file_token();
+    file_key_ = other.object->file_key();
+  }
+  return *this;
+}
+
+NaClProcessHost::NaClProcessHost(
+    const GURL& manifest_url,
+    base::File nexe_file,
+    const NaClFileToken& nexe_token,
+    scoped_ptr<NaClProcessHost::ResourceFileInfo[]> resource_files_info,
+    size_t resource_files_info_len,
+    ppapi::PpapiPermissions permissions,
+    int render_view_id,
+    uint32 permission_bits,
+    bool uses_nonsfi_mode,
+    bool off_the_record,
+    NaClAppProcessType process_type,
+    const base::FilePath& profile_directory)
     : manifest_url_(manifest_url),
       nexe_file_(nexe_file.Pass()),
       nexe_token_(nexe_token),
+      resource_files_info_(resource_files_info.Pass()),
+      resource_files_info_len_(resource_files_info_len),
       permissions_(permissions),
 #if defined(OS_WIN)
       process_launched_by_broker_(false),
 #endif
       reply_msg_(NULL),
 #if defined(OS_WIN)
       debug_exception_handler_requested_(false),
 #endif
       uses_nonsfi_mode_(uses_nonsfi_mode),
       enable_debug_stub_(false),
@@ skipping 617 matching lines @@
   }
 
   params.nexe_file = IPC::TakeFileHandleForProcess(nexe_file_.Pass(),
                                                    process_->GetData().handle);
   if (!crash_info_shmem_.ShareToProcess(process_->GetData().handle,
                                         &params.crash_info_shmem_handle)) {
     DLOG(ERROR) << "Failed to ShareToProcess() a shared memory buffer";
     return false;
   }
 
+  if (uses_nonsfi_mode_) {
+    for (size_t i = 0; i < resource_files_info_len_; ++i) {
+      IPC::PlatformFileForTransit file = IPC::TakeFileHandleForProcess(
+          resource_files_info_[i].file().Pass(), process_->GetData().handle);
+      std::string file_key = resource_files_info_[i].file_key();
+      params.resource_files.push_back(
+          // Pass an empty base::FilePath since Non-SFI mode does not use it.
+          NaClStartParams::ResourceFileInfo(file, base::FilePath(), file_key));
+    }
+  }
+
   process_->Send(new NaClProcessMsg_Start(params));
   return true;
 }
 
 // This method is called when NaClProcessHostMsg_PpapiChannelCreated is
 // received.
 void NaClProcessHost::OnPpapiChannelsCreated(
     const IPC::ChannelHandle& browser_channel_handle,
     const IPC::ChannelHandle& ppapi_renderer_channel_handle,
     const IPC::ChannelHandle& trusted_renderer_channel_handle,
@@ skipping 292 matching lines @@
         process_handle.Take(), info,
         base::MessageLoopProxy::current(),
         base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
                    weak_factory_.GetWeakPtr()));
     return true;
   }
 }
 #endif
 
 }  // namespace nacl