src/runtime/runtime-object.cc - Issue 649603003: Keyed stores to super with numeric keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 649603003: Keyed stores to super with numeric keys. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Refactoring of GetElementAttributeWithInterceptor Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index 3868011e4fa6692bf4f48ba2321f7b4b424ddc8b..2b4c731cf54ba177e90cfcfdaac5b0a1b8ec2b62 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -423,7 +423,11 @@ MUST_USE_RESULT static MaybeHandle<Object> GetOwnProperty(Isolate* isolate,

if (attrs == ABSENT) return factory->undefined_value();

// Get AccessorPair if present.

- maybe_accessors = JSObject::GetOwnElementAccessorPair(obj, index);

+ Handle<Object> structure;

+ if (JSObject::GetOwnElementStructure(obj, index).ToHandle(&structure) &&

+ structure->IsAccessorPair()) {

+ maybe_accessors = Handle<AccessorPair>::cast(structure);

+ }

// Get value if not an AccessorPair.

if (maybe_accessors.is_null()) {