Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 649563002: Set the scrollbarLayer as opaque after setupScrollbarLayer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add win pixel test result Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/Source/core/page/scrolling/ScrollingCoordinator.cpp b/Source/core/page/scrolling/ScrollingCoordinator.cpp
index 84fe3f50ba17511fc41fd07941f672c65ecdcffa..41b4bc4344f6adb689da9bb7cf9febadb40e3217 100644
--- a/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -343,14 +343,14 @@ void ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange(ScrollableArea*
scrollbarLayer = addWebScrollbarLayer(scrollableArea, orientation, webScrollbarLayer.release());
}
+ WebLayer* scrollLayer = toWebLayer(scrollableArea->layerForScrolling());
+ WebLayer* containerLayer = toWebLayer(scrollableArea->layerForContainer());
+ setupScrollbarLayer(scrollbarGraphicsLayer, scrollbarLayer, scrollLayer, containerLayer);
+
// Root layer non-overlay scrollbars should be marked opaque to disable
// blending.
bool isOpaqueScrollbar = !scrollbar->isOverlayScrollbar();
scrollbarGraphicsLayer->setContentsOpaque(isMainFrame && isOpaqueScrollbar);
-
- WebLayer* scrollLayer = toWebLayer(scrollableArea->layerForScrolling());
- WebLayer* containerLayer = toWebLayer(scrollableArea->layerForContainer());
- setupScrollbarLayer(scrollbarGraphicsLayer, scrollbarLayer, scrollLayer, containerLayer);
} else
removeWebScrollbarLayer(scrollableArea, orientation);
}

Powered by Google App Engine
This is Rietveld 408576698