Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 649563002: Set the scrollbarLayer as opaque after setupScrollbarLayer. (Closed)

Created:
6 years, 2 months ago by JungJik
Modified:
6 years, 2 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, kenneth.christiansen
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Set the scrollbarLayer as opaque after setupScrollbarLayer. setupScrollbarLayer passes scrollbarLayer to GraphicsLayer::m_contentsLayer. so if we want to change the property of scrollbarLayer, we should set the property after calling setupScrollbarLayer. currently we didn't set the scrollbarLayer as opaque. this causes to draw unnecessary quads which are not occluded in occlusion tracker. Bug=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183946

Patch Set 1 #

Patch Set 2 : add a test #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : fix a nit #

Patch Set 5 : disable_MACOSX #

Patch Set 6 : add pixel test result of an opaque scroll #

Patch Set 7 : add win pixel test result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-composited-expected.png View 1 2 3 4 5 6 Binary file 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 2 3 4 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
JungJik
PTAL :)
6 years, 2 months ago (2014-10-10 08:20:19 UTC) #2
enne (OOO)
Is it possible to write a test for this?
6 years, 2 months ago (2014-10-10 18:18:52 UTC) #3
JungJik
On 2014/10/10 18:18:52, enne wrote: > Is it possible to write a test for this? ...
6 years, 2 months ago (2014-10-11 09:01:52 UTC) #4
enne (OOO)
lgtm, thanks for the test! https://codereview.chromium.org/649563002/diff/150001/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp File Source/web/tests/ScrollingCoordinatorChromiumTest.cpp (right): https://codereview.chromium.org/649563002/diff/150001/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp#newcode500 Source/web/tests/ScrollingCoordinatorChromiumTest.cpp:500: // after scrollableAreaScrollbarLayerDidChange, Tiny ...
6 years, 2 months ago (2014-10-13 21:34:00 UTC) #7
JungJik
On 2014/10/13 21:34:00, enne wrote: > lgtm, thanks for the test! > > https://codereview.chromium.org/649563002/diff/150001/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp > ...
6 years, 2 months ago (2014-10-14 02:15:19 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-14 13:54:55 UTC) #9
JungJik
On 2014/10/14 13:54:55, jochen wrote: > lgtm @jochen : thanks for lgtm.
6 years, 2 months ago (2014-10-14 15:08:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649563002/190001
6 years, 2 months ago (2014-10-14 15:09:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27011)
6 years, 2 months ago (2014-10-14 15:59:35 UTC) #14
JungJik
On 2014/10/14 15:59:35, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-17 12:59:52 UTC) #15
enne (OOO)
lgtm, thanks!
6 years, 2 months ago (2014-10-17 18:35:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649563002/230001
6 years, 2 months ago (2014-10-18 12:00:10 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32424)
6 years, 2 months ago (2014-10-18 14:06:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649563002/250001
6 years, 2 months ago (2014-10-18 18:03:31 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 19:06:15 UTC) #23
Message was sent while issue was closed.
Committed patchset #7 (id:250001) as 183946

Powered by Google App Engine
This is Rietveld 408576698