Set the scrollbarLayer as opaque after setupScrollbarLayer.

Set the scrollbarLayer as opaque after setupScrollbarLayer.

setupScrollbarLayer passes scrollbarLayer to
GraphicsLayer::m_contentsLayer.
so if we want to change the property of scrollbarLayer,
we should set the property after calling setupScrollbarLayer.
currently we didn't set the scrollbarLayer as opaque.
this causes to draw unnecessary quads which are not
occluded in occlusion tracker.

Bug=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183946

[JungJik, 2014-10-10 08:20:18]

jungjik.lee@samsung.com changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[JungJik, 2014-10-10 08:20:19]

PTAL :)

[enne (OOO), 2014-10-10 18:18:52]

Is it possible to write a test for this?

[JungJik, 2014-10-11 09:01:52]

On 2014/10/10 18:18:52, enne wrote:
> Is it possible to write a test for this?

sure! I will upload new patch with a test.
thanks for the review.

[JungJik, 2014-10-11 16:36:46]

jungjik.lee@samsung.com changed reviewers:
+ jochen@chromium.org

[JungJik, 2014-10-11 17:11:54]

Patchset #3 (id:120001) has been deleted

[enne (OOO), 2014-10-13 21:34:00]

lgtm, thanks for the test!

https://codereview.chromium.org/649563002/diff/150001/Source/web/tests/Scroll...
File Source/web/tests/ScrollingCoordinatorChromiumTest.cpp (right):

https://codereview.chromium.org/649563002/diff/150001/Source/web/tests/Scroll...
Source/web/tests/ScrollingCoordinatorChromiumTest.cpp:500: // after
scrollableAreaScrollbarLayerDidChange,
Tiny nit: capitalize the 'A' in 'After', since it's starting a sentence.

[JungJik, 2014-10-14 02:15:19]

On 2014/10/13 21:34:00, enne wrote:
> lgtm, thanks for the test!
> 
>
https://codereview.chromium.org/649563002/diff/150001/Source/web/tests/Scroll...
> File Source/web/tests/ScrollingCoordinatorChromiumTest.cpp (right):
> 
>
https://codereview.chromium.org/649563002/diff/150001/Source/web/tests/Scroll...
> Source/web/tests/ScrollingCoordinatorChromiumTest.cpp:500: // after
> scrollableAreaScrollbarLayerDidChange,
> Tiny nit: capitalize the 'A' in 'After', since it's starting a sentence.

I've fixed the nit. thanks for the review!

[jochen (gone - plz use gerrit), 2014-10-14 13:54:55]

lgtm

[JungJik, 2014-10-14 15:08:41]

On 2014/10/14 13:54:55, jochen wrote:
> lgtm

@jochen : thanks for lgtm.

[JungJik, 2014-10-14 15:08:45]

The CQ bit was checked by jungjik.lee@samsung.com

[commit-bot: I haz the power, 2014-10-14 15:09:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649563002/190001

[commit-bot: I haz the power, 2014-10-14 15:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 15:59:35]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27011)

[JungJik, 2014-10-17 12:59:52]

On 2014/10/14 15:59:35, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27011)

PTAL again~

MACOSX does not use coordinated scrollbar. (http://goo.gl/Lnx6hA)
so scrollableAreaScrollbarLayerDidChange is not called.
I've fixed the unittest to skip in MACOSX.

And the scroll has been changed to be opaque.
so there is one pixel test failure of LayoutTest.
I've update the result image.
Thank you in advance.

[enne (OOO), 2014-10-17 18:35:05]

lgtm, thanks!

[JungJik, 2014-10-18 11:59:53]

The CQ bit was checked by jungjik.lee@samsung.com

[commit-bot: I haz the power, 2014-10-18 12:00:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649563002/230001

[commit-bot: I haz the power, 2014-10-18 14:06:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-18 14:06:48]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32424)

[JungJik, 2014-10-18 18:02:57]

The CQ bit was checked by jungjik.lee@samsung.com

[commit-bot: I haz the power, 2014-10-18 18:03:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649563002/250001

[commit-bot: I haz the power, 2014-10-18 19:06:15]

Committed patchset #7 (id:250001) as 183946

[JungJik, 2014-10-21 15:04:44]

Patchset #8 (id:270001) has been deleted