Issue 649543004: [turbofan] Correctify typed lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 649543004: [turbofan] Correctify typed lowering. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer

Modified:
6 years, 2 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Correctify typed lowering. We cannot add new JSToNumber nodes here in general, because: a) The inserted ToNumber operation screws up observability of valueOf. b) Deoptimization at ToNumber doesn't have corresponding bailout id. TEST=cctest,mjsunit R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24660

Patch Set 1 #

Patch Set 2 : Correctification #

Patch Set 3 : REBASE #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -71 lines)			Patch
	M	src/compiler/js-typed-lowering.cc	View	1	5 chunks	+43 lines, -9 lines	0 comments	Download
	M	test/cctest/compiler/test-js-typed-lowering.cc	View	1	8 chunks	+20 lines, -62 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 2 months ago (2014-10-16 11:31:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 24660 (presubmit successful).

Expand Messages | Collapse Messages