Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 649543002: Replacing MEDIA_LOOPBACK_AUDIO_CAPTURE with MEDIA_DESKTOP_AUDIO_CAPTURE (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years ago
CC:
chromium-reviews, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

TODO(sergeyu): Replace with MEDIA_DESKTOP_AUDIO_CAPTURE. BUG= Committed: https://crrev.com/aa2b0cae204860128526301896116d6833d68492 Cr-Commit-Position: refs/heads/master@{#304173}

Patch Set 1 #

Patch Set 2 : Fixed trybot build errors #

Patch Set 3 : Rebase the patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/media_stream_request.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/public/common/media_stream_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (11 generated)
anujsharma
sergeyu@chromium.org: Please review changes in chrome/browser module avi@chromium.org: Please review changes in content module
6 years, 2 months ago (2014-10-10 12:22:44 UTC) #2
Avi (use Gerrit)
LG; will rubber-stamp once area experts are satisfied.
6 years, 2 months ago (2014-10-10 15:25:52 UTC) #3
anujsharma
On 2014/10/10 15:25:52, Avi wrote: > LG; will rubber-stamp once area experts are satisfied. @sergeyu, ...
6 years, 2 months ago (2014-10-22 14:37:24 UTC) #4
anujsharma
@xhwang and DaleCurtis, Could you please take a look over this CL.
6 years, 1 month ago (2014-11-06 13:43:25 UTC) #7
xhwang
I am not familiar with this code. +grunell
6 years, 1 month ago (2014-11-06 17:03:30 UTC) #9
anujsharma
@Sergey Ulanov @DaleCurtis @ddorwin @scherkus PTAL
6 years, 1 month ago (2014-11-11 13:29:58 UTC) #12
xhwang
anujsharma: You don't want so many reviewers to review this CL. You just need the ...
6 years, 1 month ago (2014-11-11 17:12:24 UTC) #14
anujsharma
On 2014/11/11 17:12:24, xhwang wrote: > anujsharma: You don't want so many reviewers to review ...
6 years, 1 month ago (2014-11-12 02:49:53 UTC) #16
tommi (sloooow) - chröme
lgtm
6 years, 1 month ago (2014-11-13 15:37:25 UTC) #17
anujsharma
On 2014/10/10 15:25:52, Avi wrote: > LG; will rubber-stamp once area experts are satisfied. @Avi, ...
6 years, 1 month ago (2014-11-13 16:19:28 UTC) #18
xhwang
On 2014/11/12 02:49:53, anujsharma wrote: > On 2014/11/11 17:12:24, xhwang wrote: > > anujsharma: You ...
6 years, 1 month ago (2014-11-13 17:24:04 UTC) #19
Avi (use Gerrit)
lgtm stampity stamp
6 years, 1 month ago (2014-11-13 18:58:43 UTC) #20
anujsharma
On 2014/11/13 18:58:43, Avi wrote: > lgtm > > stampity stamp Thanks Avi for lgtm.
6 years, 1 month ago (2014-11-14 02:47:12 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649543002/80001
6 years, 1 month ago (2014-11-14 02:49:59 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/91702) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/81470) win_gpu ...
6 years, 1 month ago (2014-11-14 02:55:05 UTC) #25
anujsharma
Rebased the patchset and now going to land.
6 years, 1 month ago (2014-11-14 03:04:16 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649543002/170001
6 years, 1 month ago (2014-11-14 03:05:55 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:170001)
6 years, 1 month ago (2014-11-14 04:19:35 UTC) #29
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/aa2b0cae204860128526301896116d6833d68492 Cr-Commit-Position: refs/heads/master@{#304173}
6 years, 1 month ago (2014-11-14 04:20:01 UTC) #30
Wez
Guys, please make sure to check that the CL description is meaningful when reviewing patches; ...
6 years ago (2014-12-15 22:09:07 UTC) #31
anujsharma
6 years ago (2014-12-16 04:30:35 UTC) #32
Message was sent while issue was closed.
On 2014/12/15 22:09:07, Wez wrote:
> Guys, please make sure to check that the CL description is meaningful when
> reviewing patches; only the description ends up in the commit log, not the
> title.

Thanks Wez for you suggestion, i will take care of the same for future.

Powered by Google App Engine
This is Rietveld 408576698