Split extensions::MenuManager instance out from ExtensionService.

chrome/browser/extensions/menu_manager_factory.cc

Index: chrome/browser/extensions/menu_manager_factory.cc
diff --git a/chrome/browser/extensions/menu_manager_factory.cc b/chrome/browser/extensions/menu_manager_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..39e013bf9aef932b3b464c6720df52bf6004178a
--- /dev/null
+++ b/chrome/browser/extensions/menu_manager_factory.cc
@@ -0,0 +1,59 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/menu_manager_factory.h"
+
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/extension_system_factory.h"
+#include "chrome/browser/extensions/menu_manager.h"
+#include "chrome/browser/profiles/incognito_helpers.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/browser_context_keyed_service/browser_context_dependency_manager.h"
+
+namespace extensions {
+
+// static
+MenuManager* MenuManagerFactory::GetForProfile(
+    Profile* profile) {
+  return static_cast<MenuManager*>(
+      GetInstance()->GetServiceForBrowserContext(profile, true));
+}
+
+// static
+MenuManagerFactory* MenuManagerFactory::GetInstance() {
+  return Singleton<MenuManagerFactory>::get();
+}
+
+MenuManagerFactory::MenuManagerFactory()
+    : BrowserContextKeyedServiceFactory(
+        "MenuManager",
+        BrowserContextDependencyManager::GetInstance()) {
+  DependsOn(ExtensionSystemFactory::GetInstance());
+}
+
+MenuManagerFactory::~MenuManagerFactory() {}
+
+BrowserContextKeyedService*
+    MenuManagerFactory::BuildServiceInstanceFor(
+        content::BrowserContext* context) const {
+  Profile* profile = Profile::FromBrowserContext(context);
+  return new MenuManager(
+      profile,
+      ExtensionSystem::Get(profile)->state_store());
+}
+
+content::BrowserContext* MenuManagerFactory::GetBrowserContextToUse(
+    content::BrowserContext* context) const {
+  return chrome::GetBrowserContextRedirectedInIncognito(context);
+}
+
+bool MenuManagerFactory::ServiceIsCreatedWithBrowserContext() const {
+  return true;
+}
+
+bool MenuManagerFactory::ServiceIsNULLWhileTesting() const {
+  return true;

[miket_OOO, 2013/11/13 16:52:18]

Is this a TODO? Seems this would be false or else have some actual logic in it.
(This isn't a testing class, so this implementation of this method should be
false, it seems.)

[benwells, 2013/11/14 01:44:43]

Tried to chat about this. I don't understand your comment, or perhaps i don't
understand how this should be used as well as you.

My understanding is that this is used to remove BCKS's from unit tests that
don't need to always be there. Without it, as ServiceIsCreatedWithBrowserContext
is true, this would be created with every new profile in unit tests. I can't see
a reason for that - the less we have in unit tests the better. If a test
requires it, it can still call MenuManager::Get explicitly.

[miket_OOO, 2013/11/14 23:07:32]

I understand now. I thought it was more of a getter-for-testing kind of method,
but now that I see the usage elsewhere in the codebase, I get that it's a
runtime signal telling test code how to use it efficiently. Still LGTM!

+}
+
+}  // namespace extensions