Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 649513003: Fix leak reported by valgrind in VideoDestinationHandlerTest.PutFrame (Closed)

Created:
6 years, 2 months ago by perkj_chrome
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, glider+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix leak reported by valgrind in VideoDestinationHandlerTest.PutFrame This fix a problem in the unittest where the test ends before all pending cleanup tasks have completed. Revert "[MemSheriff] Suppress content_unittests leaks and uninits" This reverts commit 8ea251ca5220a7875f9d50a583575b07522d478c. BUG=422087 Committed: https://crrev.com/82c77b1fe9c13273dd115cc3a9ae9c64b414e538 Cr-Commit-Position: refs/heads/master@{#299123}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Fix broken rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M content/renderer/media/webrtc/video_destination_handler_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
perkj_chrome
Can you please review?
6 years, 2 months ago (2014-10-10 09:04:20 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 2 months ago (2014-10-10 13:32:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649513003/1
6 years, 2 months ago (2014-10-10 13:56:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/67202) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/23499) chromium_presubmit ...
6 years, 2 months ago (2014-10-10 13:59:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649513003/250001
6 years, 2 months ago (2014-10-10 15:03:53 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:250001)
6 years, 2 months ago (2014-10-10 16:18:37 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 16:19:18 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/82c77b1fe9c13273dd115cc3a9ae9c64b414e538
Cr-Commit-Position: refs/heads/master@{#299123}

Powered by Google App Engine
This is Rietveld 408576698