Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 649493003: CSS Tokenizer: Consume a single whitespace after escapes if present (Closed)

Created:
6 years, 2 months ago by Timothy Loh
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@getfraction
Project:
blink
Visibility:
Public.

Description

CSS Tokenizer: Consume a single whitespace after escapes if present The css-syntax spec says to consume a single whitespace after a hex-digit escape if present. http://dev.w3.org/csswg/css-syntax/#consume-escaped-code-point BUG=424988 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183989

Patch Set 1 #

Total comments: 2

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M Source/core/css/parser/CSSTokenizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSTokenizer.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSTokenizerTest.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Timothy Loh
Depends on https://codereview.chromium.org/662343002/ landing first (only so far as they add tests in the same ...
6 years, 2 months ago (2014-10-20 03:48:00 UTC) #2
Yoav Weiss
I'd like to see some extra tests for other newline/white-space chars. Otherwise, LGTM https://codereview.chromium.org/649493003/diff/1/Source/core/css/parser/CSSTokenizerTest.cpp File ...
6 years, 2 months ago (2014-10-20 07:42:07 UTC) #3
Timothy Loh
https://codereview.chromium.org/649493003/diff/1/Source/core/css/parser/CSSTokenizerTest.cpp File Source/core/css/parser/CSSTokenizerTest.cpp (right): https://codereview.chromium.org/649493003/diff/1/Source/core/css/parser/CSSTokenizerTest.cpp#newcode68 Source/core/css/parser/CSSTokenizerTest.cpp:68: { "wor\\6c\n\rd", "worl d" }, On 2014/10/20 07:42:07, Yoav ...
6 years, 2 months ago (2014-10-20 13:05:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649493003/20001
6 years, 2 months ago (2014-10-20 13:07:03 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 14:51:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183989

Powered by Google App Engine
This is Rietveld 408576698