Handle "Mov" which is mov, movss, movsd, and used for nacl.read.tp.

src/IceOperand.h

Index: src/IceOperand.h
diff --git a/src/IceOperand.h b/src/IceOperand.h
index cbe0095805e16d5d049bf993942016c707d3344f..4c8904e5b7bbb229b92cc540376c5f40f2d5c63c 100644
--- a/src/IceOperand.h
+++ b/src/IceOperand.h
@@ -18,7 +18,9 @@
 #ifndef SUBZERO_SRC_ICEOPERAND_H
 #define SUBZERO_SRC_ICEOPERAND_H
 
+#include "IceCfg.h"

[Jim Stichnoth, 2014/10/10 17:37:25]

Why are these includes needed?

In general, I prefer to limit includes in header files to IceDefs.h and
IceTypes.h, if possible, and add includes to the .cpp files.

[jvoung (off chromium), 2014/10/10 21:03:39]

For this, I added it because the .h file itself does Func->getContext(), and
Func->allocate(), and therefore depends on the definition of the Cfg.


Otherwise, futher down the line, if assembler_ia32.h only fwd declares stuff
from IceOperand.h instead of including it I get:

In file included from src/assembler_ia32.cpp:20:
src/assembler_ia32.h:76:30: error: member access into incomplete type 'const
Ice::ConstantRelocatable'
      : value_(fixup->value()->getOffset()), fixup_(fixup) {
                             ^
I can re-order the includes in assembler_ia32.cpp to have IceOperand.h first,
then assembler_ia32.h later, but then that has a different issue.

If I include IceOperand.h in assembler_ia32.h, then I get:

In file included from src/assembler_ia32.cpp:20:
In file included from src/assembler_ia32.h:25:
src/IceOperand.h:64:20: error: member access into incomplete type 'const
Ice::Cfg'
    dump(Func, Func->getContext()->getStrDump());
                   ^
src/IceDefs.h:39:7: note: forward declaration of 'Ice::Cfg'
class Cfg;
      ^
In file included from src/assembler_ia32.cpp:20:
In file included from src/assembler_ia32.h:25:
src/IceOperand.h:105:56: error: member access into incomplete type 'const
Ice::Cfg'
  void emit(const Cfg *Func) const override { emit(Func->getContext()); }
                                                       ^
src/IceDefs.h:39:7: note: forward declaration of 'Ice::Cfg'
class Cfg;
      ^


Any other ideas?

[Jim Stichnoth, 2014/10/13 17:41:05]

I'd say for now, just leave it as you had it.  Later we can make a pass to try
to clean up all the include issues.

FWIW, in these cases I usually just move the method definitions into the .cpp
file, and hope that LTO will close the performance gap.  There may need to be
exceptions for methods that we "*know*" are performance-critical.

 #include "IceDefs.h"
+#include "IceGlobalContext.h"
 #include "IceTypes.h"
 
 namespace Ice {
@@ -207,6 +209,7 @@ public:
     return new (Ctx->allocate<ConstantRelocatable>()) ConstantRelocatable(
         Ty, Tuple.Offset, Tuple.Name, Tuple.SuppressMangling, PoolEntryID);
   }
+  // TODO(jvoung): offset should only be int32_t, since we are ILP32.

[Jim Stichnoth, 2014/10/10 17:37:25]

I wonder if this should just be replace now with int32_t (if practical), and fix
it later to be more general if ever needed?

[jvoung (off chromium), 2014/10/10 21:03:39]

Okay, I've added a typedef and used that. I think Karl had a similar typedef,
for global initializers that we may be able to share.

   int64_t getOffset() const { return Offset; }
   IceString getName() const { return Name; }
   void setSuppressMangling(bool Value) { SuppressMangling = Value; }