Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 649433002: Revert of Enable debug fission for Release build (Closed)

Created:
6 years, 2 months ago by maniscalco
Modified:
6 years, 2 months ago
CC:
Lei Zhang, llozano
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable debug fission for Release build (patchset #1 id:1 of https://codereview.chromium.org/605623002/) Reason for revert: Speculatively reverting. Suspect it may be cause of leaks on linux asan lsan bot: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561 Original issue's description: > Enable debug fission for Release build > > This enables debug fission for Release build. If the target compiler > satisfies fission requirement, the fission is enabled for target no > matter how old the host compiler is. > > BUG=None > TEST=simple chrome for x64 platform passes with fission. > > Committed: https://crrev.com/d872dd066eb644f2d85e25429f55451cd2dd20d4 > Cr-Commit-Position: refs/heads/master@{#298925} TBR=tansell@chromium.org,mithro@mithis.com,llozano@chromium.org,llozano@google.com,yunlian@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/fc10f0bc83a90138b7b59773c6d6c1d77102a9ec Cr-Commit-Position: refs/heads/master@{#299000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maniscalco
Created Revert of Enable debug fission for Release build
6 years, 2 months ago (2014-10-09 22:45:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649433002/1
6 years, 2 months ago (2014-10-09 22:47:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 22:49:04 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 22:51:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc10f0bc83a90138b7b59773c6d6c1d77102a9ec
Cr-Commit-Position: refs/heads/master@{#299000}

Powered by Google App Engine
This is Rietveld 408576698