Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 649343003: Revert of No threadsafe statics. (Closed)

Created:
6 years, 2 months ago by mtklein
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of No threadsafe statics. (patchset #1 id:1 of https://codereview.chromium.org/654663002/) Reason for revert: Want to think about how to do this only to skialib and not to tools (gms, tests, etc.) Original issue's description: > No threadsafe statics. > > Chrome disables these for speed and code size, so we need > to disable them to make sure our code is safe when used > this way. > > int foo() { > static int32_t atomic_thing; > return sk_atomic_inc(&atomic_thing); > } > > is not safe in Chrome. Making the static global is: > > static int32_t atomic_thing; > int foo() { > return sk_atomic_inc(&atomic_thing); > } > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/cad5d3e264535c919b80e1e2a85407307961f221 TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/380d7d733953081b476fa04bf9e0093b85d0b1c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of No threadsafe statics.
6 years, 2 months ago (2014-10-13 21:49:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649343003/1
6 years, 2 months ago (2014-10-13 21:50:30 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 21:50:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 380d7d733953081b476fa04bf9e0093b85d0b1c4

Powered by Google App Engine
This is Rietveld 408576698