event_sender: Keep keyIdentifier in keypress event for Enter

content/shell/renderer/test_runner/event_sender.cc

Index: content/shell/renderer/test_runner/event_sender.cc
diff --git a/content/shell/renderer/test_runner/event_sender.cc b/content/shell/renderer/test_runner/event_sender.cc
index 7a2b07f17e77c4feadaa9473187deccdc414f017..e89549202f560d90e8714107adae022a930e5ac0 100644
--- a/content/shell/renderer/test_runner/event_sender.cc
+++ b/content/shell/renderer/test_runner/event_sender.cc
@@ -1365,7 +1365,6 @@ void EventSender::KeyDown(const std::string& code_str,
   if (generate_char) {
     WebKeyboardEvent event_char = event_up;
     event_char.type = WebInputEvent::Char;
-    event_char.keyIdentifier[0] = '\0';

[jbroman, 2014/10/14 17:53:56]

Are char events supposed to have key identifiers? The other source of them in
this files leaves this field null (though other sites do populate it).
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...

This seems suspicious to me; please ask someone who knows more about how char
events are supposed to work.

[jbroman, 2014/10/14 18:03:46]

This seems to have been intentionally added in:
https://codereview.chromium.org/27332/diff/2008/webkit/tools/test_shell/event...
though there's not much context as to *why*

[robwu, 2014/10/14 20:08:13]

I tested every key on my keyboard (US keyboard, Linux), and it seems that it is
only set for the Enter key. I've updated the CL to match this finding. To
reproduce, open the Developer tools (F12), run the following code, then press
any key within the page. Only Enter is printed:
onkeypress = function(e){console.log(e.keyIdentifier)};

(Side note: In Firefox, the "key" property (which is the successor to the
no-longer-standard keyIdentifier property) is non-empty for every key. Getting
the Keyboard events to match the spec is https://crbug.com/263724)

     view_->handleInputEvent(event_char);
   }