Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: chrome/browser/signin/signin_global_error.h

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_browsertest.cc ('k') | chrome/browser/signin/signin_global_error_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_global_error.h
diff --git a/chrome/browser/signin/signin_global_error.h b/chrome/browser/signin/signin_global_error.h
index 673b03bec4cefa68d829ab8642c91631b5135a06..86846c80437885952ed3449185e4b724959ef9f3 100644
--- a/chrome/browser/signin/signin_global_error.h
+++ b/chrome/browser/signin/signin_global_error.h
@@ -22,7 +22,7 @@ class SigninGlobalError : public GlobalErrorWithStandardBubble,
public:
SigninGlobalError(SigninErrorController* error_controller,
Profile* profile);
- virtual ~SigninGlobalError();
+ ~SigninGlobalError() override;
// Returns true if there is an authentication error.
bool HasError();
@@ -37,24 +37,24 @@ class SigninGlobalError : public GlobalErrorWithStandardBubble,
FRIEND_TEST_ALL_PREFIXES(SigninGlobalErrorTest, AuthStatusEnumerateAllErrors);
// KeyedService:
- virtual void Shutdown() override;
+ void Shutdown() override;
// GlobalErrorWithStandardBubble:
- virtual bool HasMenuItem() override;
- virtual int MenuItemCommandID() override;
- virtual base::string16 MenuItemLabel() override;
- virtual void ExecuteMenuItem(Browser* browser) override;
- virtual bool HasBubbleView() override;
- virtual base::string16 GetBubbleViewTitle() override;
- virtual std::vector<base::string16> GetBubbleViewMessages() override;
- virtual base::string16 GetBubbleViewAcceptButtonLabel() override;
- virtual base::string16 GetBubbleViewCancelButtonLabel() override;
- virtual void OnBubbleViewDidClose(Browser* browser) override;
- virtual void BubbleViewAcceptButtonPressed(Browser* browser) override;
- virtual void BubbleViewCancelButtonPressed(Browser* browser) override;
+ bool HasMenuItem() override;
+ int MenuItemCommandID() override;
+ base::string16 MenuItemLabel() override;
+ void ExecuteMenuItem(Browser* browser) override;
+ bool HasBubbleView() override;
+ base::string16 GetBubbleViewTitle() override;
+ std::vector<base::string16> GetBubbleViewMessages() override;
+ base::string16 GetBubbleViewAcceptButtonLabel() override;
+ base::string16 GetBubbleViewCancelButtonLabel() override;
+ void OnBubbleViewDidClose(Browser* browser) override;
+ void BubbleViewAcceptButtonPressed(Browser* browser) override;
+ void BubbleViewCancelButtonPressed(Browser* browser) override;
// SigninErrorController::Observer:
- virtual void OnErrorChanged() override;
+ void OnErrorChanged() override;
// The Profile this service belongs to.
Profile* profile_;
« no previous file with comments | « chrome/browser/signin/signin_browsertest.cc ('k') | chrome/browser/signin/signin_global_error_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698