Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/signin/profile_identity_provider.h

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/profile_identity_provider.h
diff --git a/chrome/browser/signin/profile_identity_provider.h b/chrome/browser/signin/profile_identity_provider.h
index b2291f43169329b2004e918b3b8e53f8a90138e4..aa1b1688ede9014bffb44447c77415d9ce880b08 100644
--- a/chrome/browser/signin/profile_identity_provider.h
+++ b/chrome/browser/signin/profile_identity_provider.h
@@ -20,20 +20,20 @@ class ProfileIdentityProvider : public IdentityProvider,
ProfileIdentityProvider(SigninManagerBase* signin_manager,
ProfileOAuth2TokenService* token_service,
LoginUIService* login_ui_service);
- virtual ~ProfileIdentityProvider();
+ ~ProfileIdentityProvider() override;
// IdentityProvider:
- virtual std::string GetActiveUsername() override;
- virtual std::string GetActiveAccountId() override;
- virtual OAuth2TokenService* GetTokenService() override;
- virtual bool RequestLogin() override;
+ std::string GetActiveUsername() override;
+ std::string GetActiveAccountId() override;
+ OAuth2TokenService* GetTokenService() override;
+ bool RequestLogin() override;
// SigninManagerBase::Observer:
- virtual void GoogleSigninSucceeded(const std::string& account_id,
- const std::string& username,
- const std::string& password) override;
- virtual void GoogleSignedOut(const std::string& account_id,
- const std::string& username) override;
+ void GoogleSigninSucceeded(const std::string& account_id,
+ const std::string& username,
+ const std::string& password) override;
+ void GoogleSignedOut(const std::string& account_id,
+ const std::string& username) override;
private:
SigninManagerBase* const signin_manager_;
« no previous file with comments | « chrome/browser/signin/principals_message_filter.h ('k') | chrome/browser/signin/profile_oauth2_token_service_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698