Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: chrome/browser/signin/fake_signin_manager.h

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/fake_signin_manager.h
diff --git a/chrome/browser/signin/fake_signin_manager.h b/chrome/browser/signin/fake_signin_manager.h
index 6128012da1d9077d82845f6f08a32b03cd7c1423..8e91531ac9891e567db29feee927ab04c8a2450d 100644
--- a/chrome/browser/signin/fake_signin_manager.h
+++ b/chrome/browser/signin/fake_signin_manager.h
@@ -25,7 +25,7 @@ class Profile;
class FakeSigninManagerBase : public SigninManagerBase {
public:
explicit FakeSigninManagerBase(Profile* profile);
- virtual ~FakeSigninManagerBase();
+ ~FakeSigninManagerBase() override;
// Helper function to be used with
// KeyedService::SetTestingFactory(). In order to match
@@ -42,7 +42,7 @@ class FakeSigninManagerBase : public SigninManagerBase {
class FakeSigninManager : public SigninManager {
public:
explicit FakeSigninManager(Profile* profile);
- virtual ~FakeSigninManager();
+ ~FakeSigninManager() override;
void set_auth_in_progress(const std::string& username) {
possibly_invalid_username_ = username;
@@ -54,16 +54,15 @@ class FakeSigninManager : public SigninManager {
void FailSignin(const GoogleServiceAuthError& error);
- virtual void StartSignInWithRefreshToken(
+ void StartSignInWithRefreshToken(
const std::string& refresh_token,
const std::string& username,
const std::string& password,
const OAuthTokenFetchedCallback& oauth_fetched_callback) override;
- virtual void SignOut(signin_metrics::ProfileSignout signout_source_metric)
- override;
+ void SignOut(signin_metrics::ProfileSignout signout_source_metric) override;
- virtual void CompletePendingSignin() override;
+ void CompletePendingSignin() override;
};
#endif // !defined (OS_CHROMEOS)
« no previous file with comments | « chrome/browser/signin/fake_profile_oauth2_token_service.h ('k') | chrome/browser/signin/principals_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698