Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3848)

Unified Diff: chrome/browser/signin/fake_profile_oauth2_token_service.h

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/fake_account_tracker_service.h ('k') | chrome/browser/signin/fake_signin_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/fake_profile_oauth2_token_service.h
diff --git a/chrome/browser/signin/fake_profile_oauth2_token_service.h b/chrome/browser/signin/fake_profile_oauth2_token_service.h
index 4eadb7d4817ec3f7d8341a3f59df00222dc8abf6..9a5b97c82318da520cbc7da0473251f5440d3c48 100644
--- a/chrome/browser/signin/fake_profile_oauth2_token_service.h
+++ b/chrome/browser/signin/fake_profile_oauth2_token_service.h
@@ -56,21 +56,20 @@ class FakeProfileOAuth2TokenService
};
FakeProfileOAuth2TokenService();
- virtual ~FakeProfileOAuth2TokenService();
+ ~FakeProfileOAuth2TokenService() override;
// Overriden to make sure it works on Android.
- virtual bool RefreshTokenIsAvailable(
- const std::string& account_id) const override;
+ bool RefreshTokenIsAvailable(const std::string& account_id) const override;
// Overriden to make sure it works on iOS.
- virtual void LoadCredentials(const std::string& primary_account_id) override;
+ void LoadCredentials(const std::string& primary_account_id) override;
- virtual std::vector<std::string> GetAccounts() override;
+ std::vector<std::string> GetAccounts() override;
// Overriden to make sure it works on Android. Simply calls
// IssueRefreshToken().
- virtual void UpdateCredentials(const std::string& account_id,
- const std::string& refresh_token) override;
+ void UpdateCredentials(const std::string& account_id,
+ const std::string& refresh_token) override;
// Sets the current refresh token. If |token| is non-empty, this will invoke
// OnRefreshTokenAvailable() on all Observers, otherwise this will invoke
@@ -116,24 +115,24 @@ class FakeProfileOAuth2TokenService
protected:
// OAuth2TokenService overrides.
- virtual void FetchOAuth2Token(RequestImpl* request,
- const std::string& account_id,
- net::URLRequestContextGetter* getter,
- const std::string& client_id,
- const std::string& client_secret,
- const ScopeSet& scopes) override;
-
- virtual OAuth2AccessTokenFetcher* CreateAccessTokenFetcher(
+ void FetchOAuth2Token(RequestImpl* request,
+ const std::string& account_id,
+ net::URLRequestContextGetter* getter,
+ const std::string& client_id,
+ const std::string& client_secret,
+ const ScopeSet& scopes) override;
+
+ OAuth2AccessTokenFetcher* CreateAccessTokenFetcher(
const std::string& account_id,
net::URLRequestContextGetter* getter,
OAuth2AccessTokenConsumer* consumer) override;
- virtual void InvalidateOAuth2Token(const std::string& account_id,
- const std::string& client_id,
- const ScopeSet& scopes,
- const std::string& access_token) override;
+ void InvalidateOAuth2Token(const std::string& account_id,
+ const std::string& client_id,
+ const ScopeSet& scopes,
+ const std::string& access_token) override;
- virtual net::URLRequestContextGetter* GetRequestContext() override;
+ net::URLRequestContextGetter* GetRequestContext() override;
private:
// Helper function to complete pending requests - if |all_scopes| is true,
« no previous file with comments | « chrome/browser/signin/fake_account_tracker_service.h ('k') | chrome/browser/signin/fake_signin_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698