Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 649313002: add ganesh checkbox to skfiddle interface (Closed)

Created:
6 years, 2 months ago by humper
Modified:
6 years, 2 months ago
Reviewers:
tfarina, jcgregorio, mtklein
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Integrate the ganesh checkbox into the hash and DB #

Total comments: 12

Patch Set 3 : Don't forget to delete the context factory #

Patch Set 4 : Fix DB update code for workspaces" #

Patch Set 5 : Don't delete the factory too early since we defer rendering #

Patch Set 6 : Style cleanups from tfarina #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -28 lines) Patch
M experimental/webtry/main.cpp View 1 2 3 4 5 4 chunks +20 lines, -2 lines 0 comments Download
M experimental/webtry/res/js/webtry.js View 1 3 chunks +10 lines, -1 line 0 comments Download
M experimental/webtry/scripts/fiddle_gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/setup/continue_install_jail.sh View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/setup/setup_jail.sh View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/sidebar.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M experimental/webtry/templates/template.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/webtry/webtry.go View 1 2 3 4 5 16 chunks +39 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
humper
PTAL
6 years, 2 months ago (2014-10-13 21:21:23 UTC) #2
tfarina
lgtm just minor comments. https://codereview.chromium.org/649313002/diff/110001/experimental/webtry/main.cpp File experimental/webtry/main.cpp (right): https://codereview.chromium.org/649313002/diff/110001/experimental/webtry/main.cpp#newcode16 experimental/webtry/main.cpp:16: #include "GrContextFactory.h" might keep this ...
6 years, 2 months ago (2014-10-13 21:28:13 UTC) #3
humper
https://codereview.chromium.org/649313002/diff/110001/experimental/webtry/main.cpp File experimental/webtry/main.cpp (right): https://codereview.chromium.org/649313002/diff/110001/experimental/webtry/main.cpp#newcode16 experimental/webtry/main.cpp:16: #include "GrContextFactory.h" On 2014/10/13 21:28:12, tfarina wrote: > might ...
6 years, 2 months ago (2014-10-13 21:50:07 UTC) #4
mtklein
lgtm
6 years, 2 months ago (2014-10-13 22:02:07 UTC) #6
humper
Committed patchset #6 (id:270001) manually as ccb54895c614632fd01d22b64ab614921f980eb1 (presubmit successful).
6 years, 2 months ago (2014-10-13 22:12:35 UTC) #7
humper
6 years, 2 months ago (2014-10-13 23:02:47 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #6 id:270001) has been created in
https://codereview.chromium.org/655633003/ by humper@google.com.

The reason for reverting is: adding -Dskia_mesa=1 broke production; don't yet
know why and don't want to leave things in a broken state..

Powered by Google App Engine
This is Rietveld 408576698