Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 649303002: Mojo: Add a "remote" channel endpoint ID generator. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Add a "remote" channel endpoint ID generator. (But don't use it yet.) Also change the terminology slightly, and just use the all-around confusing term "remote ID" (since what we really mean is "remotely-allocated local ID" or "locally-allocated remote ID", both of which mean the same thing but are used in different contexts ... and both of which are very long phrases). R=yzshen@chromium.org Committed: https://crrev.com/9650ad0d17562dd8acd57de719f8af54e81eed8c Cr-Commit-Position: refs/heads/master@{#299375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -38 lines) Patch
M mojo/edk/system/channel_endpoint_id.h View 4 chunks +40 lines, -18 lines 0 comments Download
M mojo/edk/system/channel_endpoint_id.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M mojo/edk/system/channel_endpoint_id_unittest.cc View 3 chunks +59 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
(brettw would have more context, but he's buried in a committee at an undisclosed location.)
6 years, 2 months ago (2014-10-13 20:39:34 UTC) #1
yzshen1
lgtm
6 years, 2 months ago (2014-10-13 21:03:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649303002/1
6 years, 2 months ago (2014-10-13 21:07:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 22:04:13 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 22:04:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9650ad0d17562dd8acd57de719f8af54e81eed8c
Cr-Commit-Position: refs/heads/master@{#299375}

Powered by Google App Engine
This is Rietveld 408576698