Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Unified Diff: chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc

Issue 649223003: easy-unlock: Tighten finch check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move a couple of tests to finch enabled suite and add a no finch test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/easy_unlock_service_regular.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc
diff --git a/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc b/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc
index 9c3fa4c445bfd5336a001cbce419f44c6a7ec028..10f5f075c70cecfd6c6895aae266beb81cb325aa 100644
--- a/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc
+++ b/chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc
@@ -136,23 +136,12 @@ class EasyUnlockServiceTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(EasyUnlockServiceTest);
};
-// Tests that EasyUnlock is on by default.
-IN_PROC_BROWSER_TEST_F(EasyUnlockServiceTest, DefaultOn) {
- EXPECT_TRUE(service()->IsAllowed());
-#if defined(GOOGLE_CHROME_BUILD)
- EXPECT_TRUE(HasEasyUnlockApp());
-#endif
-}
-
+IN_PROC_BROWSER_TEST_F(EasyUnlockServiceTest, NoFinchNoService) {
+ EXPECT_FALSE(service()->IsAllowed());
#if defined(GOOGLE_CHROME_BUILD)
-IN_PROC_BROWSER_TEST_F(EasyUnlockServiceTest, UnloadsOnSuspend) {
- EXPECT_TRUE(HasEasyUnlockApp());
- power_manager_client()->SendSuspendImminent();
EXPECT_FALSE(HasEasyUnlockApp());
- power_manager_client()->SendSuspendDone();
- EXPECT_TRUE(HasEasyUnlockApp());
-}
#endif
+}
class EasyUnlockServiceNoBluetoothTest : public EasyUnlockServiceTest {
public:
@@ -191,6 +180,23 @@ class EasyUnlockServiceFinchEnabledTest : public EasyUnlockServiceTest {
DISALLOW_COPY_AND_ASSIGN(EasyUnlockServiceFinchEnabledTest);
};
+IN_PROC_BROWSER_TEST_F(EasyUnlockServiceFinchEnabledTest, Enabled) {
+ EXPECT_TRUE(service()->IsAllowed());
+#if defined(GOOGLE_CHROME_BUILD)
+ EXPECT_TRUE(HasEasyUnlockApp());
+#endif
+}
+
+#if defined(GOOGLE_CHROME_BUILD)
+IN_PROC_BROWSER_TEST_F(EasyUnlockServiceFinchEnabledTest, UnloadsOnSuspend) {
+ EXPECT_TRUE(HasEasyUnlockApp());
+ power_manager_client()->SendSuspendImminent();
+ EXPECT_FALSE(HasEasyUnlockApp());
+ power_manager_client()->SendSuspendDone();
+ EXPECT_TRUE(HasEasyUnlockApp());
+}
+#endif
+
// Tests that policy can override finch to turn easy unlock off.
IN_PROC_BROWSER_TEST_F(EasyUnlockServiceFinchEnabledTest, PolicyOveride) {
EXPECT_TRUE(service()->IsAllowed());
« no previous file with comments | « no previous file | chrome/browser/signin/easy_unlock_service_regular.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698