Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 649223003: easy-unlock: Tighten finch check. (Closed)

Created:
6 years, 2 months ago by xiyuan
Modified:
6 years, 2 months ago
Reviewers:
Tim Song
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

easy-unlock: Tighten finch check. Tighten finch check a bit so that the missing trial is treated as disable. BUG=423016 Committed: https://crrev.com/67eeb55ce2ee3b915b6cd7d6197a2a812d7c452a Cr-Commit-Position: refs/heads/master@{#299408}

Patch Set 1 #

Patch Set 2 : move a couple of tests to finch enabled suite and add a no finch test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M chrome/browser/signin/easy_unlock_service_browsertest_chromeos.cc View 1 2 chunks +20 lines, -14 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
xiyuan
6 years, 2 months ago (2014-10-13 21:34:59 UTC) #2
Tim Song
lgtm
6 years, 2 months ago (2014-10-13 22:40:56 UTC) #3
Tim Song
Can you add a EasyUnlockServiceNoFinchTrialTest to the browser tests?
6 years, 2 months ago (2014-10-13 22:42:34 UTC) #4
xiyuan
On 2014/10/13 22:42:34, Tim Song wrote: > Can you add a EasyUnlockServiceNoFinchTrialTest to the browser ...
6 years, 2 months ago (2014-10-13 23:03:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649223003/140001
6 years, 2 months ago (2014-10-14 00:23:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:140001)
6 years, 2 months ago (2014-10-14 00:43:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:44:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67eeb55ce2ee3b915b6cd7d6197a2a812d7c452a
Cr-Commit-Position: refs/heads/master@{#299408}

Powered by Google App Engine
This is Rietveld 408576698