Issue 649213002: Oilpan: eager resource disposal on MemoryCache eviction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 649213002: Oilpan: eager resource disposal on MemoryCache eviction. (Closed)

Created:
6 years, 2 months ago by sof

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, haraken, Mike West

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: eager resource disposal on MemoryCache eviction. Promptly let go of a memory cache entry's Resource when evicting it, and do not wait until the next GC to strike. This provides the same behavior & lifetime for the resource as non-Oilpan. R=mkwst BUG=420068 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183606

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	Source/core/fetch/MemoryCache.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	Source/core/fetch/MemoryCache.cpp	View		2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649213002/1

6 years, 2 months ago (2014-10-13 14:35:41 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 183606

6 years, 2 months ago (2014-10-13 14:39:23 UTC) #6

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages