Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: content/browser/service_worker/service_worker_cache.cc

Issue 649203005: [ServiceWorkerCache] Put should replace an existing entry to meet spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@staticize
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache.cc
diff --git a/content/browser/service_worker/service_worker_cache.cc b/content/browser/service_worker/service_worker_cache.cc
index fbebdc1be21bbf91c8f635814b53f7618defad7a..93a50ba66a17393ff2a6b04db8e64b6d3edc76ff 100644
--- a/content/browser/service_worker/service_worker_cache.cc
+++ b/content/browser/service_worker/service_worker_cache.cc
@@ -817,6 +817,26 @@ void ServiceWorkerCache::PutImpl(scoped_ptr<PutContext> put_context) {
return;
}
+ ServiceWorkerFetchRequest* request_ptr = put_context->request.get();
+ disk_cache::Backend* backend_ptr = put_context->cache->backend_.get();
+
+ net::CompletionCallback doom_entry_callback =
+ base::Bind(PutDidDoomEntry, base::Passed(put_context.Pass()));
+
+ int rv = backend_ptr->DoomEntry(request_ptr->url.spec(), doom_entry_callback);
+ if (rv != net::ERR_IO_PENDING)
+ doom_entry_callback.Run(rv);
+}
+
+// static
+void ServiceWorkerCache::PutDidDoomEntry(scoped_ptr<PutContext> put_context,
+ int doom_rv) {
+ if (!put_context->cache || !put_context->cache->backend_) {
+ put_context->callback.Run(ErrorTypeStorage,
+ scoped_ptr<ServiceWorkerResponse>(),
+ scoped_ptr<storage::BlobDataHandle>());
+ }
+
disk_cache::Entry** entry_ptr = &put_context->cache_entry;
ServiceWorkerFetchRequest* request_ptr = put_context->request.get();
disk_cache::Backend* backend_ptr = put_context->cache->backend_.get();

Powered by Google App Engine
This is Rietveld 408576698