Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt

Issue 649183007: Add console errors and usecounter when srcset candidates are dropped (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: improved log messages Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html ('k') | LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt » ('j') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt
diff --git a/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt b/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt
index 7d8dfd3ba9ba63f66dd0983d7e6834b7de7c6117..29f22cc8abae49395153f92441e51fcdcbca78d9 100644
--- a/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt
+++ b/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt
@@ -1,9 +1,97 @@
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'w' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'w' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'h' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'h' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an 'h' descriptor and no 'w' descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an 'h' descriptor and no 'w' descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'w' descriptors or a mix of 'x' and 'w' descriptors.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'w' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'w' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'h' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'h' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an 'h' descriptor and no 'w' descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
+CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an 'h' descriptor and no 'w' descriptor.
+CONSOLE ERROR: Dropped srcset candidate resources/blue-100-px-square.png
PASS successfullyParsed is true
TEST COMPLETE
PASS document.getElementById("foo").clientWidth==200 is true
PASS document.getElementById("foo2").clientWidth==200 is true
+PASS document.getElementById("foo3").clientWidth==200 is true
+PASS document.getElementById("foo4").clientWidth==200 is true
+PASS document.getElementById("foo5").clientWidth==200 is true
+PASS document.getElementById("foo6").clientWidth==200 is true
+PASS document.getElementById("foo7").clientWidth==200 is true
+PASS document.getElementById("foo8").clientWidth==200 is true
+PASS document.getElementById("foo9").clientWidth==200 is true
+PASS document.getElementById("foo10").clientWidth==200 is true
This test passes if the image below is a 200px green square when the deviceScaleFactor is 1.
It tests that the 1x resource is ignored since it contains invalid descriptors.
The 2x resource has an intrinsic width of 200px, since it's a 400px wide image at 2x DPR.
-
+
« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html ('k') | LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt » ('j') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698