LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt - Issue 649183007: Add console errors and usecounter when srcset candidates are dropped

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt

Issue 649183007: Add console errors and usecounter when srcset candidates are dropped (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: improved log messages Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt ('k') | Source/core/frame/UseCounter.h » ('j') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.

	2 CONSOLE ERROR: Dropped srcset candidate bar.jpg

	3 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown d escriptor.

	4 CONSOLE ERROR: Dropped srcset candidate foo.jpg

	5 CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.

	6 CONSOLE ERROR: Dropped srcset candidate bar.jpg

	7 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.

	8 CONSOLE ERROR: Dropped srcset candidate bar.jpg

	9 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown d escriptor.

	10 CONSOLE ERROR: Dropped srcset candidate foo.jpg

	11 CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.

	12 CONSOLE ERROR: Dropped srcset candidate bar.jpg

	13 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.

	14 CONSOLE ERROR: Dropped srcset candidate bar.jpg

	15 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown d escriptor.

	16 CONSOLE ERROR: Dropped srcset candidate foo.jpg

	17 CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.

	18 CONSOLE ERROR: Dropped srcset candidate bar.jpg

	19 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has multiple 'h' descriptors or a mix of 'x' and 'h' descriptors.

	20 CONSOLE ERROR: Dropped srcset candidate bar.jpg

	21 CONSOLE ERROR: Failed parsing 'srcset' attribute value since it has an unknown d escriptor.

	22 CONSOLE ERROR: Dropped srcset candidate foo.jpg

	23 CONSOLE ERROR: Failed parsing 'srcset' attribute value since its 'x' descriptor is invalid.

	24 CONSOLE ERROR: Dropped srcset candidate bar.jpg

1 PASS successfullyParsed is true	25 PASS successfullyParsed is true

2	26

3 TEST COMPLETE	27 TEST COMPLETE

4 PASS document.getElementById("foo").clientWidth==200 is true	28 PASS document.getElementById("foo").clientWidth==200 is true

5 This test passes if the img tag below is a green square regardless of the scale factor. It ensures that invalid inputs are ignored and well-formed images are ch osen regardless of their qualifiers, once they are the only candidate left	29 This test passes if the img tag below is a green square regardless of the scale factor. It ensures that invalid inputs are ignored and well-formed images are ch osen regardless of their qualifiers, once they are the only candidate left

6	30

OLD	NEW