LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html - Issue 649183007: Add console errors and usecounter when srcset candidates are dropped

Side by Side Diff: LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

Issue 649183007: Add console errors and usecounter when srcset candidates are dropped (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: improved log messages Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-ignore-double-descriptor-expected.txt ('k') | LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt » ('j') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 window.targetScaleFactor = 1;	4 window.targetScaleFactor = 1;

5 </script>	5 </script>

6 <script src="resources/srcset-helper.js"></script>	6 <script src="resources/srcset-helper.js"></script>

7 <script src="../../resources/js-test.js"></script>	7 <script src="../../resources/js-test.js"></script>

8 <script>	8 <script>

9 addEventListener("load", function() {	9 addEventListener("load", function() {

10 shouldBeTrue('document.getElementById("foo").clientWidth==200');	10 shouldBeTrue('document.getElementById("foo").clientWidth==200');

11 shouldBeTrue('document.getElementById("foo2").clientWidth==200');	11 shouldBeTrue('document.getElementById("foo2").clientWidth==200');

	12 shouldBeTrue('document.getElementById("foo3").clientWidth==200');

	13 shouldBeTrue('document.getElementById("foo4").clientWidth==200');

	14 shouldBeTrue('document.getElementById("foo5").clientWidth==200');

	15 shouldBeTrue('document.getElementById("foo6").clientWidth==200');

	16 shouldBeTrue('document.getElementById("foo7").clientWidth==200');

	17 shouldBeTrue('document.getElementById("foo8").clientWidth==200');

	18 shouldBeTrue('document.getElementById("foo9").clientWidth==200');

	19 shouldBeTrue('document.getElementById("foo10").clientWidth==200');

12 }, false);	20 }, false);

13 </script>	21 </script>

14 </head>	22 </head>

15	23

16 <body id="body">	24 <body id="body">

17 <div>This test passes if the image below is a 200px green square when the de viceScaleFactor is 1.</div>	25 <div>This test passes if the image below is a 200px green square when the de viceScaleFactor is 1.</div>

18 <div>It tests that the 1x resource is ignored since it contains invalid desc riptors.</div>	26 <div>It tests that the 1x resource is ignored since it contains invalid desc riptors.</div>

19 <div>The 2x resource has an intrinsic width of 200px, since it's a 400px wid e image at 2x DPR.</div>	27 <div>The 2x resource has an intrinsic width of 200px, since it's a 400px wid e image at 2x DPR.</div>

20 <img id="foo" src="" srcset="resources/blue-100-px-square.png 43q 1x dfs 3dd , resources/green-400-px-square.png 2x">	28 <img id="foo" src="" srcset="resources/blue-100-px-square.png 43q 1x dfs 3dd , resources/green-400-px-square.png 2x">

21 <img id="foo2" src="" srcset="resources/blue-100-px-square.png 300q, resourc es/green-400-px-square.png 2x">	29 <img id="foo2" src="" srcset="resources/blue-100-px-square.png 300q, resourc es/green-400-px-square.png 2x">

	30 <img id="foo3" src="" srcset="resources/blue-100-px-square.png 100w 100w, re sources/green-400-px-square.png 2x">

	31 <img id="foo4" src="" srcset="resources/blue-100-px-square.png 100h 100h, re sources/green-400-px-square.png 2x">

	32 <img id="foo5" src="" srcset="resources/blue-100-px-square.png 100x 100h, re sources/green-400-px-square.png 2x">

	33 <img id="foo6" src="" srcset="resources/blue-100-px-square.png 100x 100w, re sources/green-400-px-square.png 2x">

	34 <img id="foo7" src="" srcset="resources/blue-100-px-square.png -100w, resour ces/green-400-px-square.png 2x">

	35 <img id="foo8" src="" srcset="resources/blue-100-px-square.png -100h, resour ces/green-400-px-square.png 2x">

	36 <img id="foo9" src="" srcset="resources/blue-100-px-square.png -1x, resource s/green-400-px-square.png 2x">

	37 <img id="foo10" src="" srcset="resources/blue-100-px-square.png 100h, resour ces/green-400-px-square.png 2x">

22 </body>	38 </body>

23 </html>	39 </html>

OLD	NEW