Non-SFI Mode: Build gpu/ libraries by PNaCl toolchain for nacl_helper_nonsfi.

gpu/command_buffer/command_buffer_nacl.gyp

Index: gpu/command_buffer/command_buffer_nacl.gyp
diff --git a/gpu/command_buffer/command_buffer_nacl.gyp b/gpu/command_buffer/command_buffer_nacl.gyp
index aabd1c84a41f8519fed4b3bcb0ea015135866a7e..79fd46e597d5a8ed97e545b6cb3e9d8898db5003 100644
--- a/gpu/command_buffer/command_buffer_nacl.gyp
+++ b/gpu/command_buffer/command_buffer_nacl.gyp
@@ -11,7 +11,7 @@
     'command_buffer.gypi',
   ],
   'conditions': [
-    ['disable_nacl==0 and disable_nacl_untrusted==0', {

[Mark Seaborn, 2014/10/20 15:43:59]

common.gypi says:

    # This flag is only used when disable_nacl==0 and disables all those
    # subcomponents which would require the installation of a native_client
    # untrusted toolchain.
    'disable_nacl_untrusted%': 0,

I think you should leave the "disable_nacl_untrusted" condition here, because
the 'build_nonsfi_helper' target depends on the toolchain as much as the
'build_irt' target.

Leaving the condition here keeps the logic simpler.

I don't know why the "disable_nacl_untrusted" option exists in addition to
disable_nacl.  I don't know if anyone is using or testing it.  Maybe it's
something we should remove.

[hidehiko, 2014/10/20 19:02:35]

Done.

+    ['disable_nacl==0', {
       'targets': [
         {
           'target_name': 'gles2_utils_nacl',
@@ -22,13 +22,25 @@
             'nlib_target': 'libgles2_utils_nacl.a',
             'build_glibc': 0,
             'build_newlib': 0,
-            'build_irt': 1,
+            'build_irt': 0,

[Mark Seaborn, 2014/10/20 15:44:00]

With the simplification, this can stay as build_irt=1.

[hidehiko, 2014/10/20 19:02:34]

Done.

+            'build_pnacl_newlib': 0,
+            'build_nonsfi_helper': 1,
           },
           'dependencies': [
             '../../native_client/tools.gyp:prep_toolchain',
-            '../../base/base_nacl.gyp:base_nacl',
+            '../../base/base_nacl.gyp:base_nacl_nonsfi',
             '../../third_party/khronos/khronos.gyp:khronos_headers',
           ],
+          'conditions': [
+            ['disable_nacl_untrusted==0', {
+              'variables': {
+                'build_irt': 1,
+              },
+              'dependencies': [
+                '../../base/base_nacl.gyp:base_nacl',

[Mark Seaborn, 2014/10/20 15:43:59]

With the simplification, this can go in the 'dependencies' list above, right?

[hidehiko, 2014/10/20 19:02:34]

Exactly. Done.

+              ],
+            }],
+          ],
         },
       ],
     }],