Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 649153002: Align -webkit-transform-origin behaviour with transform-origin behaviour (Closed)

Created:
6 years, 2 months ago by Timothy Loh
Modified:
6 years, 2 months ago
Reviewers:
dstockwell
CC:
dstockwell, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, rune+blink, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Align -webkit-transform-origin behaviour with transform-origin behaviour Currently -webkit-transform-origin is a shorthand while transform-origin is not. This patch makes the vendor-prefixed property behave the same as non-prefixed property. This has minor changes to serialization, which the test changes document. In doing so we fix a crash in parsing some invalid values. BUG=405323 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183588

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -46 lines) Patch
M LayoutTests/fast/css/script-tests/transform-origin-parsing.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/transform-inline-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/transform-inline-style-remove-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/transform-origin-parsing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/svg-style-expected.txt View 1 2 1 chunk +1 line, -3 lines 0 comments Download
A LayoutTests/transforms/webkit-transform-origin-crash.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/transforms/webkit-transform-origin-crash-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/transitions/unprefixed-transform-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSProperties.in View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +2 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 2 months ago (2014-10-13 05:03:48 UTC) #2
dstockwell
lgtm
6 years, 2 months ago (2014-10-13 06:46:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649153002/200001
6 years, 2 months ago (2014-10-13 06:50:32 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 07:56:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:200001) as 183588

Powered by Google App Engine
This is Rietveld 408576698