Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 649073004: Do not reshow the text message after navigating to the next video. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not reshow the text message after navigating to the next video. Currently the message is reshown if the animation is not finished. However, since the video is changed and the text message is related to the previous video, it's the best to just hide it immediately when switching videos. TEST=Tested manually by playing multiple videos and clicking play with the CTRL key pressed. BUG=422120 Committed: https://crrev.com/ea319e730a0002e972853c996ec41c454a90e3aa Cr-Commit-Position: refs/heads/master@{#300189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/file_manager/video_player/js/media_controls.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mtomasz
@yoshiki: PTAL. Thanks.
6 years, 2 months ago (2014-10-15 02:28:55 UTC) #2
yoshiki
On 2014/10/15 02:28:55, mtomasz wrote: > @yoshiki: PTAL. Thanks. Thank you for doing this. The ...
6 years, 2 months ago (2014-10-17 00:45:44 UTC) #3
mtomasz
On 2014/10/17 00:45:44, yoshiki wrote: > On 2014/10/15 02:28:55, mtomasz wrote: > > @yoshiki: PTAL. ...
6 years, 2 months ago (2014-10-17 00:49:55 UTC) #4
yoshiki
On 2014/10/17 00:49:55, mtomasz wrote: > On 2014/10/17 00:45:44, yoshiki wrote: > > On 2014/10/15 ...
6 years, 2 months ago (2014-10-17 17:35:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649073004/1
6 years, 2 months ago (2014-10-18 00:00:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-18 00:16:45 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 00:17:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea319e730a0002e972853c996ec41c454a90e3aa
Cr-Commit-Position: refs/heads/master@{#300189}

Powered by Google App Engine
This is Rietveld 408576698