Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 649053003: Add chrome:help to URLs not allowed in incognito (Closed)

Created:
6 years, 2 months ago by michaelpg
Modified:
6 years, 1 month ago
CC:
chromium-reviews, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add chrome:help to URLs not allowed in incognito In Chrome OS, chrome://help (the About page) redirects to chrome://settings/help. But the Settings page should not be loaded in Incognito (and causes the browser to crash). BUG=426618 R=ben@chromium.org Committed: https://crrev.com/3dadf61adc2041013c03c817af15ef49466581b9 Cr-Commit-Position: refs/heads/master@{#302698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
michaelpg
Tiny fix to prevent a crash.
6 years, 2 months ago (2014-10-23 22:51:04 UTC) #1
michaelpg
Ping: This one-liner is needed to prevent a crash. We don't load chrome://settings in incognito. ...
6 years, 1 month ago (2014-10-28 16:31:54 UTC) #2
michaelpg
sky@, could you review this 1-liner crash fix? I have not heard back from Ben.
6 years, 1 month ago (2014-11-04 18:42:23 UTC) #4
sky
LGTM
6 years, 1 month ago (2014-11-04 21:00:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649053003/1
6 years, 1 month ago (2014-11-04 21:38:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 23:05:44 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 23:07:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dadf61adc2041013c03c817af15ef49466581b9
Cr-Commit-Position: refs/heads/master@{#302698}

Powered by Google App Engine
This is Rietveld 408576698