Win Video Capture: Add device blacklisting, used for IPCamera and YouCam, collect UMA for those

media/video/capture/win/video_capture_device_factory_win.cc

Index: media/video/capture/win/video_capture_device_factory_win.cc
diff --git a/media/video/capture/win/video_capture_device_factory_win.cc b/media/video/capture/win/video_capture_device_factory_win.cc
index 4f68c6edb3841a622246848f9dd42562e1e96d3c..daef0e8694809abb5cb6a076731c696006008214 100644
--- a/media/video/capture/win/video_capture_device_factory_win.cc
+++ b/media/video/capture/win/video_capture_device_factory_win.cc
@@ -9,6 +9,7 @@
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
+#include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/win/metro.h"
@@ -27,6 +28,16 @@ using Names = media::VideoCaptureDevice::Names;
 
 namespace media {
 
+// We would like to avoid enumerating and/or using certain devices due to they
+// provoking crashes or any other reason. This enum is defined for the purposes
+// of UMA collection. Existing entries cannot be removed.
+enum BlacklistedCameraNames{
+  BLACKLISTED_CAMERA_GOOGLE_CAMERA_ADAPTER,
+  BLACKLISTED_CAMERA_IP_CAMERA,
+  BLACKLISTED_CAMERA_CYBERLINK_WEBCAM_SPLITTER,
+  BLACKLISTED_CAMERA_MAX  // This one must be last.
+};
+
 // Lazy Instance to initialize the MediaFoundation Library.
 class MFInitializerSingleton {
  public:
@@ -37,6 +48,16 @@ class MFInitializerSingleton {
 static base::LazyInstance<MFInitializerSingleton> g_mf_initialize =
     LAZY_INSTANCE_INITIALIZER;
 
+// Blacklisted devices are identified by a characteristic prefix of the name.
+// This prefix is used case-insensitively.
+static const char* kBlacklistedCameraNames[] = {
+  // Name of a fake DirectShow filter on computers with GTalk installed.
+  {"Google Camera Adapter"},
+  // The following two software WebCams cause crashes.
+  {"IP Camera [JPEG/MJPEG]"},
+  {"CyberLink Webcam Splitter"}
+};
+
 static void EnsureMediaFoundationInit() {
   g_mf_initialize.Get();
 }
@@ -90,6 +111,20 @@ static bool EnumerateVideoDevicesMediaFoundation(IMFActivate*** devices,
   return SUCCEEDED(MFEnumDeviceSources(attributes, devices, count));
 }
 
+static bool IsDeviceBlackListed(const std::string& name) {
+  DCHECK_EQ(static_cast<int>(arraysize(kBlacklistedCameraNames)),
+            BLACKLISTED_CAMERA_MAX);
+  for (size_t i = 0; i < arraysize(kBlacklistedCameraNames); ++i) {
+    if (StartsWithASCII(name, kBlacklistedCameraNames[i], false)) {
+      DVLOG(1) << "Enumerated blacklisted device: " << name;
+      UMA_HISTOGRAM_ENUMERATION("Media.VideoCapture.BlacklistedDevice",
+          i, BLACKLISTED_CAMERA_MAX + 1);
+      return true;
+    }
+  }
+  return false;
+}
+
 static void GetDeviceNamesDirectShow(
     const CLSID& class_id,
     const Name::CaptureApiType capture_api_type,
@@ -128,21 +163,14 @@ static void GetDeviceNamesDirectShow(
     if (FAILED(hr) || name.type() != VT_BSTR)
       continue;
 
-    // Ignore all VFW drivers and the special Google Camera Adapter.
-    // Google Camera Adapter is not a real DirectShow camera device.
-    // VFW are very old Video for Windows drivers that can not be used.
+    // Ignore all Video For Windows (VFW) old drivers that can not be used.
     const wchar_t* str_ptr = V_BSTR(&name);
-    // Name of a fake DirectShow filter that exist on computers with
-    // GTalk installed.
-    static const char kGoogleCameraAdapter[] = "google camera adapter";
-    if (wcsstr(str_ptr, L"(VFW)") != NULL ||
-        LowerCaseEqualsASCII(str_ptr,
-                             str_ptr + arraysize(kGoogleCameraAdapter) - 1,
-                             kGoogleCameraAdapter)) {
+    if (wcsstr(str_ptr, L"(VFW)") != NULL)

[tommi (sloooow) - chröme, 2014/10/13 10:32:01]

I think this check (and |str_ptr|) should also be removed since it's related to
the check for the Google Camera Adapter.

[perkj_chrome, 2014/10/13 10:46:40]

I think there might be other VFW drivers we want to avoid so I think this is
fine. This was done a loooong time ago though (before I joined Chrome) so I am
not sure if it is still a problem or not. 

[mcasas, 2014/10/13 11:35:26]

Removing VFW blacklisting. Rationale follows:

Wikipedia on Video For Windows [1] says:
"Video for Windows was mostly replaced by the July 1996 release 
of ActiveMovie, later known as DirectShow. [...] Video for 
Windows was still used for video capture until the release of
Windows Driver Model capture drivers, which only started to 
become popular in 2000."

VfW drivers are supported via Direct Show VfW drivers [2]; such
are not enumerated since they have CLSID_VfwCapture and we 
don't use such CLSID [3,4].


[1] http://en.wikipedia.org/wiki/Video_for_Windows
[2]
http://msdn.microsoft.com/en-us/library/windows/desktop/dd407319(v=vs.85).aspx
[3]
https://code.google.com/p/chromium/codesearch#chromium/src/media/video/captur...
[4]
https://code.google.com/p/chromium/codesearch#chromium/src/media/video/captur...

       continue;
-    }
-
     const std::string device_name(base::SysWideToUTF8(str_ptr));
+    if (IsDeviceBlackListed(device_name))
+      continue;
+
     name.Reset();
     hr = prop_bag->Read(L"DevicePath", name.Receive(), 0);
     std::string id;