Add a mojoPrivate API that exposes mojo to component apps/extensions.

Add a mojoPrivate API that exposes mojo to component apps/extensions.

Some component apps and extensions use private extension APIs to
communicate with their browser components. This CL adds the mojoPrivate
API as a way to use mojo directly from Javascript without needing to
create a private API.

BUG=448565, 448569
Committed: https://crrev.com/2cc22656103e5df811de911b693eadc55d3ad0b2
Cr-Commit-Position: refs/heads/master@{#311385}

[Sam McNally, 2015-01-13 03:07:39]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2015-01-13 04:17:23]

Patchset #2 (id:40001) has been deleted

[Sam McNally, 2015-01-13 04:17:30]

Patchset #2 (id:60001) has been deleted

[Sam McNally, 2015-01-13 04:22:03]

Patchset #2 (id:80001) has been deleted

[Sam McNally, 2015-01-13 04:22:22]

Patchset #2 (id:100001) has been deleted

[Sam McNally, 2015-01-13 04:25:41]

sammc@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-01-13 20:24:20]

Please add a BUG.

[not at google - send to devlin, 2015-01-13 21:46:46]

lgtm

https://codereview.chromium.org/649003003/diff/120001/extensions/common/api/m...
File extensions/common/api/mojo_private.idl (right):

https://codereview.chromium.org/649003003/diff/120001/extensions/common/api/m...
extensions/common/api/mojo_private.idl:16: DefineCallback callback);
You might want to call this "factory", that's the AMD terminology right?

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/mod...
File extensions/renderer/module_system.cc (right):

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/mod...
extensions/renderer/module_system.cc:667: // the particular dependency is one
loaded by ModuleSystem, attempt to load
first part is a little hard to parse - I eventually realised it's equivalent to
"if a dependency is not available, and either the module or this dependency is
managed by ModuleSystem, attempt to load it".

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/mod...
extensions/renderer/module_system.cc:668: // it. Ignore other dependencies; the
module requesting them should be
could you mention what these other dependencies might be?

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/res...
File extensions/renderer/resources/mojo_private_custom_bindings.js (right):

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/res...
extensions/renderer/resources/mojo_private_custom_bindings.js:11: let
pendingModuleRejections = [];
I don't see this used anywhere?

[Sam McNally, 2015-01-13 23:48:43]

https://codereview.chromium.org/649003003/diff/120001/extensions/common/api/m...
File extensions/common/api/mojo_private.idl (right):

https://codereview.chromium.org/649003003/diff/120001/extensions/common/api/m...
extensions/common/api/mojo_private.idl:16: DefineCallback callback);
On 2015/01/13 21:46:46, kalman wrote:
> You might want to call this "factory", that's the AMD terminology right?

Done.

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/mod...
File extensions/renderer/module_system.cc (right):

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/mod...
extensions/renderer/module_system.cc:667: // the particular dependency is one
loaded by ModuleSystem, attempt to load
On 2015/01/13 21:46:46, kalman wrote:
> first part is a little hard to parse - I eventually realised it's equivalent
to
> "if a dependency is not available, and either the module or this dependency is
> managed by ModuleSystem, attempt to load it".

Done.

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/mod...
extensions/renderer/module_system.cc:668: // it. Ignore other dependencies; the
module requesting them should be
On 2015/01/13 21:46:46, kalman wrote:
> could you mention what these other dependencies might be?

Done.

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/res...
File extensions/renderer/resources/mojo_private_custom_bindings.js (right):

https://codereview.chromium.org/649003003/diff/120001/extensions/renderer/res...
extensions/renderer/resources/mojo_private_custom_bindings.js:11: let
pendingModuleRejections = [];
On 2015/01/13 21:46:46, kalman wrote:
> I don't see this used anywhere?

Removed.

[Sam McNally, 2015-01-13 23:48:55]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2015-01-13 23:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649003003/140001

[commit-bot: I haz the power, 2015-01-14 01:25:35]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2015-01-14 01:26:32]

Patchset 3 (id:??) landed as
https://crrev.com/2cc22656103e5df811de911b693eadc55d3ad0b2
Cr-Commit-Position: refs/heads/master@{#311385}

[not at google - send to devlin, 2015-01-16 20:25:13]

kalman@chromium.org changed reviewers:
+ adamk@chromium.org

[not at google - send to devlin, 2015-01-16 20:25:14]

https://codereview.chromium.org/649003003/diff/140001/extensions/renderer/res...
File extensions/renderer/resources/mojo_private_custom_bindings.js (right):

https://codereview.chromium.org/649003003/diff/140001/extensions/renderer/res...
extensions/renderer/resources/mojo_private_custom_bindings.js:9: let binding =
require('binding').Binding.create('mojoPrivate');
I was curious about using "let" over "var", and apparently "let" is behind a
flag that *may* get turned off. So, it's safer to use "var" for now.