Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 6490014: Make the size of menulists on Linux the same size as on Windows. (Closed)

Created:
8 years, 9 months ago by tony
Modified:
8 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make the size of menulists on Linux the same size as on Windows. We do this by adding an extra flag in MenuListExtraParams to suppress the border in the same case that we don't draw it on Windows. We also change ButtonExtraParams because paintMenuList calls into paintButton. BUG=41729 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74986

Patch Set 1 #

Total comments: 1

Patch Set 2 : fill #

Patch Set 3 : handle border radius #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -16 lines) Patch
M ui/gfx/native_theme_linux.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gfx/native_theme_linux.cc View 1 2 3 chunks +29 lines, -16 lines 0 comments Download
M webkit/glue/webthemeengine_impl_linux.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tony
This is a 2 sided patch. The webkit side is here: https://bugs.webkit.org/show_bug.cgi?id=51152
8 years, 9 months ago (2011-02-11 00:56:28 UTC) #1
xiyuan
http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc File ui/gfx/native_theme_linux.cc (right): http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc#newcode505 ui/gfx/native_theme_linux.cc:505: skrect.set(rect.x() + 1, rect.y() + 1, kRight - 1, ...
8 years, 9 months ago (2011-02-11 01:06:21 UTC) #2
tony
On 2011/02/11 01:06:21, xiyuan wrote: > http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc > File ui/gfx/native_theme_linux.cc (right): > > http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc#newcode505 > ...
8 years, 9 months ago (2011-02-11 18:06:10 UTC) #3
xiyuan
LGTM
8 years, 9 months ago (2011-02-11 18:09:55 UTC) #4
dgrogan
On 2011/02/11 18:06:10, tony wrote: > On 2011/02/11 01:06:21, xiyuan wrote: > > http://codereview.chromium.org/6490014/diff/1/ui/gfx/native_theme_linux.cc > ...
8 years, 9 months ago (2011-02-11 19:24:03 UTC) #5
xiyuan
On 2011/02/11 19:24:03, dgrogan wrote: > On 2011/02/11 18:06:10, tony wrote: > > On 2011/02/11 ...
8 years, 9 months ago (2011-02-11 19:29:19 UTC) #6
tony
Hmm, yes, I get the double border, although I'm not sure why. I'll try to ...
8 years, 9 months ago (2011-02-11 19:30:12 UTC) #7
tony
Updated to handle border radius.
8 years, 9 months ago (2011-02-11 23:34:30 UTC) #8
dgrogan.goog
Mine doesn't count, but: LGTM.
8 years, 9 months ago (2011-02-12 02:39:59 UTC) #9
xiyuan
8 years, 9 months ago (2011-02-14 17:41:19 UTC) #10
LGTM

Ping me when this gets in and I'll update the ChromeOS part.

Powered by Google App Engine
This is Rietveld 408576698