Issue 6489007: Always use ProfileSyncService::ShowErrorUI to handle error links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6489007: Always use ProfileSyncService::ShowErrorUI to handle error links. (Closed)

Created:
9 years, 10 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
John Gregg, johnnyg, jhawkins, tim (not reviewing)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Always use ProfileSyncService::ShowErrorUI to handle error links. BUG=chromium-os:11931 TEST=Test handling of sync errors from settings/personal page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74502

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -14 lines)			Patch
M	chrome/browser/dom_ui/options/personal_options_handler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options/personal_options_handler.cc	View	2 chunks	+18 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stevenjb

This is the change I probably should have made instead of http://codereview.chromium.org/6459014/. We should never ...

9 years, 10 months ago (2011-02-10 21:32:35 UTC) #1

John Gregg

9 years, 10 months ago (2011-02-10 21:33:46 UTC) #2

On 2011/02/10 21:32:35, Steven Bennetts wrote:
> This is the change I probably should have made instead of
> http://codereview.chromium.org/6459014/. We should never be calling the code
in
> ShowSyncLoginDialog() from an action (error) link.

LGTM

Expand Messages | Collapse Messages