components/invalidation/gcm_network_channel.cc - Issue 648873003: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/gcm_network_channel.cc

Issue 648873003: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/google/core/browser/google_url_tracker.cc ('k') | components/policy/core/common/cloud/device_management_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/gcm_network_channel.cc

diff --git a/components/invalidation/gcm_network_channel.cc b/components/invalidation/gcm_network_channel.cc

index 277213148199738e146f9e831c85e02e9cb9b44f..142cc8ffffe4b5d686289d2ceb5139fc159da6da 100644

--- a/components/invalidation/gcm_network_channel.cc

+++ b/components/invalidation/gcm_network_channel.cc

@@ -5,6 +5,7 @@

#include "base/base64.h"

#include "base/i18n/time_formatting.h"

#include "base/metrics/histogram.h"

+#include "base/profiler/scoped_profile.h"

#include "base/sha1.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

@@ -223,6 +224,11 @@ void GCMNetworkChannel::OnGetTokenComplete(

}

void GCMNetworkChannel::OnURLFetchComplete(const net::URLFetcher* source) {

+ // TODO(vadimt): Remove ScopedProfile below once crbug.com/422577 is fixed.

+ tracked_objects::ScopedProfile tracking_profile(

+ FROM_HERE_WITH_EXPLICIT_FUNCTION(

+ "422577 GCMNetworkChannel::OnURLFetchComplete"));

DCHECK(CalledOnValidThread());

DCHECK_EQ(fetcher_, source);

// Free fetcher at the end of function.