Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 648843002: Remove obsolete interface. (Closed)

Created:
6 years, 2 months ago by newt (away)
Modified:
6 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete interface in SigninManager. SigninManager.Observer was renamed to SignInFlowObserver, which should now be used instead. BUG=421058 Committed: https://crrev.com/1baf0bad7eef2ec6ca75e34babbdefb296722ecd Cr-Commit-Position: refs/heads/master@{#299191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
6 years, 2 months ago (2014-10-10 19:27:49 UTC) #2
nyquist
lgtm, but could you expand a little bit on the commit message for new readers ...
6 years, 2 months ago (2014-10-10 19:39:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648843002/1
6 years, 2 months ago (2014-10-10 20:53:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 21:35:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:35:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1baf0bad7eef2ec6ca75e34babbdefb296722ecd
Cr-Commit-Position: refs/heads/master@{#299191}

Powered by Google App Engine
This is Rietveld 408576698