chrome/browser/ui/views/javascript_app_modal_dialog_views.cc - Issue 648833004: Componentize app_modal_dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

Issue 648833004: Componentize app_modal_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

diff --git a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

index adfcac34f165f4839894db7320a79b8775e17b00..a237c54bdd09f610afdb4587880eaa29259e3024 100644

--- a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

+++ b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

@@ -5,9 +5,9 @@

#include "chrome/browser/ui/views/javascript_app_modal_dialog_views.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h"

#include "chrome/browser/ui/views/constrained_window_views.h"

-#include "chrome/grit/generated_resources.h"

+#include "components/app_modal_dialogs/javascript_app_modal_dialog.h"

+#include "grit/components_strings.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/events/keycodes/keyboard_codes.h"

#include "ui/views/controls/message_box_view.h"