Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/app_modal_dialogs/app_modal_dialog.cc

Issue 648833004: Componentize app_modal_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: git cl try Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/app_modal_dialogs/app_modal_dialog.cc
diff --git a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog.cc b/components/app_modal_dialogs/app_modal_dialog.cc
similarity index 73%
rename from chrome/browser/ui/app_modal_dialogs/app_modal_dialog.cc
rename to components/app_modal_dialogs/app_modal_dialog.cc
index edd94572dd7e4cb87150d0d69fcf67383d021962..f19f0022bf1218fa46b163bfc4d4725ac955bd95 100644
--- a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog.cc
+++ b/components/app_modal_dialogs/app_modal_dialog.cc
@@ -2,18 +2,33 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h"
+#include "components/app_modal_dialogs/app_modal_dialog.h"
#include "base/logging.h"
-#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h"
-#include "chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h"
-#include "content/public/browser/notification_service.h"
+#include "base/run_loop.h"
+#include "components/app_modal_dialogs/app_modal_dialog_queue.h"
+#include "components/app_modal_dialogs/native_app_modal_dialog.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_delegate.h"
using content::WebContents;
+namespace {
+
+AppModalDialogNotifier* notifier_ = NULL;
+
+} // namespace
+
+AppModalDialogNotifier::AppModalDialogNotifier() {
+ DCHECK(!notifier_);
+ notifier_ = this;
+}
+
+AppModalDialogNotifier::~AppModalDialogNotifier() {
+ DCHECK(notifier_);
+ notifier_ = NULL;
+}
+
AppModalDialog::AppModalDialog(WebContents* web_contents,
const base::string16& title)
: title_(title),
@@ -30,11 +45,8 @@ AppModalDialog::~AppModalDialog() {
void AppModalDialog::ShowModalDialog() {
web_contents_->GetDelegate()->ActivateContents(web_contents_);
CreateAndShowDialog();
-
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_APP_MODAL_DIALOG_SHOWN,
- content::Source<AppModalDialog>(this),
- content::NotificationService::NoDetails());
+ if (notifier_)
+ notifier_->Notify(this);
}
void AppModalDialog::CreateAndShowDialog() {

Powered by Google App Engine
This is Rietveld 408576698