Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/app_modal_dialogs/DEPS

Issue 648833004: Componentize app_modal_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: owners Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/app_modal_dialogs/BUILD.gn ('K') | « components/app_modal_dialogs/BUILD.gn ('k') | components/app_modal_dialogs/app_modal_dialog.h » ('j') | components/app_modal_dialogs/app_modal_dialog.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/app_modal_dialogs/DEPS
diff --git a/components/web_contents_delegate_android/DEPS b/components/app_modal_dialogs/DEPS
similarity index 63%
copy from components/web_contents_delegate_android/DEPS
copy to components/app_modal_dialogs/DEPS
index e560a548e26d90b77b84b4114fb99c2570ec185c..bc65d1ffb897f2f94ed177b44d4d02d8d7e6dd9e 100644
--- a/components/web_contents_delegate_android/DEPS
+++ b/components/app_modal_dialogs/DEPS
@@ -1,7 +1,9 @@
include_rules = [
"+content/public/browser",
"+content/public/common",
msw 2014/10/22 22:53:32 I don't think anything from ui/base is included [y
- "+jni",
+ "+grit/components_strings.h",
+ "+net/base",
+ "+ui/aura",
"+ui/base",
msw 2014/10/22 22:53:32 Is anything from ui/base actually included?
oshima 2014/10/23 00:44:12 They are in javascript_dialog_manager, which I mov
msw 2014/10/23 18:41:21 Acknowledged.
"+ui/gfx",
]
« components/app_modal_dialogs/BUILD.gn ('K') | « components/app_modal_dialogs/BUILD.gn ('k') | components/app_modal_dialogs/app_modal_dialog.h » ('j') | components/app_modal_dialogs/app_modal_dialog.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698