components/OWNERS - Issue 648833004: Componentize app_modal_dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/OWNERS

Issue 648833004: Componentize app_modal_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc ('K') | « chrome/test/base/ui_test_utils.cc ('k') | components/app_modal_dialogs.gypi » ('j') | components/app_modal_dialogs/app_modal_dialog.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 blundell@chromium.org	1 blundell@chromium.org

2 caitkp@chromium.org	2 caitkp@chromium.org

3 erikwright@chromium.org	3 erikwright@chromium.org

4 jochen@chromium.org	4 jochen@chromium.org

5	5

	6 per-file app_modal_dialog*=avi@chromium.org

	7

6 # Can not match autofill* due to crbug.com/397984	8 # Can not match autofill* due to crbug.com/397984

7 per-file autofill.gypi=estade@chromium.org	9 per-file autofill.gypi=estade@chromium.org

8 per-file autofill.gypi=isherman@chromium.org	10 per-file autofill.gypi=isherman@chromium.org

9 per-file autofill_strings.grdp=estade@chromium.org	11 per-file autofill_strings.grdp=estade@chromium.org

10 per-file autofill_strings.grdp=isherman@chromium.org	12 per-file autofill_strings.grdp=isherman@chromium.org

11	13

12 per-file bookmarks.gypi=sky@chromium.org	14 per-file bookmarks.gypi=sky@chromium.org

13	15

14 per-file cloud_devices*=gene@chromium.org	16 per-file cloud_devices*=gene@chromium.org

15 per-file cloud_devices*=vitalybuka@chromium.org	17 per-file cloud_devices*=vitalybuka@chromium.org

(...skipping 214 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
230	232

231 per-file wifi.gypi=mef@chromium.org	233 per-file wifi.gypi=mef@chromium.org

232	234

233 per-file *.isolate=csharp@chromium.org	235 per-file *.isolate=csharp@chromium.org

234 per-file *.isolate=maruel@chromium.org	236 per-file *.isolate=maruel@chromium.org

235	237

236 # These are for the common case of adding or removing tests. If you're making	238 # These are for the common case of adding or removing tests. If you're making

237 # structural changes, please get a review from one of the overall components	239 # structural changes, please get a review from one of the overall components

238 # OWNERS.	240 # OWNERS.

239 per-file components_tests.gyp=*	241 per-file components_tests.gyp=*

OLD	NEW