Componentize app_modal_dialog

components/app_modal_dialogs/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//build/config/ui.gni")
+
+static_library("app_modal_dialogs") {
+  sources = [
+    "app_modal_dialog.cc",
+    "app_modal_dialog.h",
+    "app_modal_dialog_test_util.h",
+    "app_modal_dialog_queue.cc",
+    "app_modal_dialog_queue.h",
+    "javascript_app_modal_dialog.cc",
+    "javascript_app_modal_dialog.h",
+    "native_app_modal_dialog.h"
+  ]
+
+  deps = [
+    "//components/strings",
+    "//content/public/browser",
+    "//content/public/common",

[msw, 2014/10/22 22:53:32]

Is this needed for content/public/browser? Is an explicit dep needed?

+    "//extensions/common",

[msw, 2014/10/22 22:53:32]

Where is extensions used at all? Ditto for the dep below?

[oshima, 2014/10/23 00:44:12]

They're in javascript_dialog_manager. I moved that to the next CL, so that's why
you didn't see it. I removed them and will be added in the next CL.

[msw, 2014/10/23 18:41:21]

Acknowledged.

+    "//extensions/strings",
+    "//skia",

[msw, 2014/10/22 22:53:32]

Is this needed for ui/gfx or something? Why is an explicit dep needed?

[oshima, 2014/10/23 00:44:12]

This is for SkMatrix44.h which is included via aura -> compositor -> gfx ->
skia.
My undestanding is that you need this skia dependency in this case. I'm happy to
change if this is wrong, so please let me know.

[msw, 2014/10/23 18:41:21]

Acknowledged.

+  ]
+
+  if (use_aura) {
+    deps += [ "//ui/aura" ]
+  }
+}