components/app_modal_dialogs.gypi - Issue 648833004: Componentize app_modal_dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/app_modal_dialogs.gypi

Issue 648833004: Componentize app_modal_dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: owners Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'targets': [

	6 {

	7 'target_name': 'app_modal_dialogs',

	8 'type': 'static_library',

	9 'dependencies': [

	10 '../skia/skia.gyp:skia',

	11 '../content/content.gyp:content_browser',
	msw 2014/10/22 22:53:32 nit: fix indent on this line and the line below. nit: fix indent on this line and the line below. oshima 2014/10/23 00:44:12 indent looks correct? Show quoted text On 2014/10/22 22:53:32, msw wrote: > nit: fix indent on this line and the line below. indent looks correct? msw 2014/10/23 18:41:21 Sorry... I'm losing it! Show quoted text On 2014/10/23 00:44:12, oshima wrote: > On 2014/10/22 22:53:32, msw wrote: > > nit: fix indent on this line and the line below. > > indent looks correct? Sorry... I'm losing it!
	12 '../content/content.gyp:content_common',

	13 'components_strings.gyp:components_strings',

	14 ],

	15 'include_dirs': [

	16 '..',

	17 ],

	18 'sources': [

	19 'app_modal_dialogs/app_modal_dialog.cc',

	20 'app_modal_dialogs/app_modal_dialog.h',

	21 'app_modal_dialogs/app_modal_dialog_test_util.h',

	22 'app_modal_dialogs/app_modal_dialog_queue.cc',

	23 'app_modal_dialogs/app_modal_dialogs/app_modal_dialog_queue.h',
	msw 2014/10/22 22:53:32 Remove one of the app_modal_dialogs dir mentions.. Remove one of the app_modal_dialogs dir mentions... oshima 2014/10/23 00:44:12 Done. Show quoted text On 2014/10/22 22:53:32, msw wrote: > Remove one of the app_modal_dialogs dir mentions... Done.
	24 'app_modal_dialogs/javascript_app_modal_dialog.cc',

	25 'app_modal_dialogs/javascript_app_modal_dialog.h',

	26 'app_modal_dialogs/native_app_modal_dialog.h'

	27 ],

	28 'conditions': [

	29 ['use_aura==1',{

	30 'dependencies': [

	31 '../ui/aura/aura.gyp:aura',

	32 ],

	33 }]

	34 ],

	35 },

	36 ],

	37 }

OLD	NEW

« components/OWNERS ('K') | « components/OWNERS ('k') | components/app_modal_dialogs/BUILD.gn » ('j') | components/app_modal_dialogs/BUILD.gn » ('J')