Componentize app_modal_dialog

chrome/browser/chrome_notification_types.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
 #define CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
 
 #include "build/build_config.h"
 
 #if defined(ENABLE_EXTENSIONS)
@@ skipping 106 matching lines @@
   // browsers have closed. This is sent if the user chooses to exit (via exit
   // menu item or keyboard shortcut) or to restart the process (such as in flags
   // page), not if Chrome exits by some other means (such as the user closing
   // the last window). No source or details are passed.
   //
   // Note that receiving this notification does not necessarily mean the process
   // will exit because the shutdown process can be cancelled by an unload
   // handler.  Use APP_TERMINATING for such needs.
   NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST,
 
   // Application-modal dialogs -----------------------------------------------

[msw, 2014/10/22 22:53:31]

nit: if you remove the only actually dialog-related notification here, maybe the
comment should be updated; not sure to what...

[oshima, 2014/10/23 00:44:11]

I didn't remove the section and that's why I didn't remove it. You seems to be
correct that the above title is only for this notification.

Maybe  // Inforbar --- ? I can change whatever you want so please let me know.

[msw, 2014/10/23 18:41:21]

NOTIFICATION_METRIC_EVENT_DURATION can probably be removed, it's not observed
anywhere, afaict. NOTIFICATION_TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED seems
like it ought to be moved to extensions/browser/notification_types.h. If you
update those two, then you can retitle this section "Infobars" for the remaining
two infobar notifications.

Otherwise, I'd just remove this title and let them fall under
"Application-wide", I guess?

[oshima, 2014/10/23 21:44:18]

I sent you CL that removes NOTIFICATION_METRIC_EVENT_DURATION and the code that
notifies this.
I'll merge it once it's landed.

For NOTIFICATION_TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED, I talked to one of
extensions
team and they want to keep it here because it's notified/observered inside
chrome.

I removed the title and moved them to "Application-wide" instead.

[msw, 2014/10/23 22:01:24]

Acknowledged.

 
-  // Sent after an application-modal dialog has been shown. The source
-  // is the dialog.
-  NOTIFICATION_APP_MODAL_DIALOG_SHOWN,
-
   // This message is sent when a new InfoBar has been added to an
   // InfoBarService.  The source is a Source<InfoBarService> with a pointer to
   // the InfoBarService the InfoBar was added to.  The details is a
   // Details<InfoBar::AddedDetails>.
   NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED,
 
   // This message is sent when an InfoBar is about to be removed from an
   // InfoBarService.  The source is a Source<InfoBarService> with a pointer to
   // the InfoBarService the InfoBar was removed from.  The details is a
   // Details<InfoBar::RemovedDetails>.
@@ skipping 546 matching lines @@
   // Note:-
   // Currently only Content and Chrome define and use notifications.
   // Custom notifications not belonging to Content and Chrome should start
   // from here.
   NOTIFICATION_CHROME_END,
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_