Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 64883003: Revert 233815 "Quota: Implement QuotaBackendImpl" (Closed)

Created:
7 years, 1 month ago by nhiroki
Modified:
7 years, 1 month ago
Reviewers:
nhiroki
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 233815 "Quota: Implement QuotaBackendImpl" This breaks content_unittests on some bots. http://build.chromium.org/p/chromium.linux/builders/Linux Aura/builds/11164 > Quota: Implement QuotaBackendImpl > > This introduces QuotaBackendImpl working as bridge among FileSystemUsageCache, > QuotaManager and QuotaReservationManager. The backend will be created by > FileSystemContext and retained by QuotaReservationManager. > > > BUG=303443 > TEST=content_unittests --gtest_filter=QuotaBackendImplTest.* > TEST=content_unittests --gtest_filter=QuotaReservationManagerTest.* > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/61593002 TBR=nhiroki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -541 lines) Patch
M trunk/src/content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/webkit/browser/fileapi/obfuscated_file_util.h View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/webkit/browser/fileapi/quota/quota_backend_impl.h View 1 chunk +0 lines, -103 lines 0 comments Download
D trunk/src/webkit/browser/fileapi/quota/quota_backend_impl.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D trunk/src/webkit/browser/fileapi/quota/quota_backend_impl_unittest.cc View 1 chunk +0 lines, -243 lines 0 comments Download
M trunk/src/webkit/browser/fileapi/quota/quota_reservation_buffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/webkit/browser/fileapi/quota/quota_reservation_buffer.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M trunk/src/webkit/browser/fileapi/quota/quota_reservation_manager.h View 5 chunks +18 lines, -16 lines 0 comments Download
M trunk/src/webkit/browser/fileapi/quota/quota_reservation_manager.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc View 5 chunks +15 lines, -8 lines 0 comments Download
M trunk/src/webkit/browser/fileapi/sandbox_file_system_backend_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/webkit/storage_browser.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nhiroki
7 years, 1 month ago (2013-11-08 08:44:10 UTC) #1
nhiroki
7 years, 1 month ago (2013-11-08 08:44:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r233828.

Powered by Google App Engine
This is Rietveld 408576698