Add compositor_unittests, aura_unittests, and ash_unittests to chromium_builder_tests because we'll…

Add compositor_unittests, aura_unittests, and ash_unittests to chromium_builder_tests because we'll need these targets on the Windows builders before we can remove the Win Aura bots.

BUG=316199
R=cpu@chromium.org, scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233675

[cpu_(ooo_6.6-7.5), 2013-11-07 18:59:47]

lgtm 

ash_unittests however give me pause. +Gab

Is this running on Win8 boxes?

[gab, 2013-11-07 19:02:35]

On 2013/11/07 18:59:47, cpu wrote:
> lgtm 
> 
> ash_unittests however give me pause. +Gab
> 
> Is this running on Win8 boxes?

ash_unittests can only run on Win8 AFAIK and are reportedly flaky:
http://crbug.com/303478

Is that your question?

[jam, 2013-11-07 19:16:28]

my plan was to build that target on the windows builder, so that the win 8 aura
builder can get its build from the generic windows builder and not a specialized
win aura builder (which we can remove for fun and profit).

adding iannucci for sanity checking the above

[jam, 2013-11-07 19:17:36]

and to be very clear: ash_unittests wouldn't run on any new builders.

the existing win7 test bots would run compositor_unittests and aura_unittests,
per the linked bug, so that we can drop the win7 aura bots.

[scottmg, 2013-11-07 19:24:13]

lgtm

[scottmg, 2013-11-07 19:24:50]

https://codereview.chromium.org/64883002/diff/210001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/64883002/diff/210001/build/all.gyp#newcode360
build/all.gyp:360: '../ui/compositor/compositor.gyp:compositor_unittests',
is this aura-dependent?

[jam, 2013-11-07 19:36:05]

https://codereview.chromium.org/64883002/diff/210001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/64883002/diff/210001/build/all.gyp#newcode360
build/all.gyp:360: '../ui/compositor/compositor.gyp:compositor_unittests',
On 2013/11/07 19:24:50, scottmg wrote:
> is this aura-dependent?

good question, it's not, however it looked like the test binary was only needed
now for aura builders, so i left the change as minimal as possible. i don't feel
strongly though

[iannucci, 2013-11-07 20:10:05]

On 2013/11/07 19:16:28, jam wrote:
> my plan was to build that target on the windows builder, so that the win 8
aura
> builder can get its build from the generic windows builder and not a
specialized
> win aura builder (which we can remove for fun and profit).
> 
> adding iannucci for sanity checking the above

Yep that sounds good to me. I'm assuming that the addition of these targets
won't introduce significant amounts of time to the build (i.e. the delta will be
< ~5min)

[jam, 2013-11-07 20:22:35]

On 2013/11/07 20:10:05, iannucci wrote:
> On 2013/11/07 19:16:28, jam wrote:
> > my plan was to build that target on the windows builder, so that the win 8
> aura
> > builder can get its build from the generic windows builder and not a
> specialized
> > win aura builder (which we can remove for fun and profit).
> > 
> > adding iannucci for sanity checking the above
> 
> Yep that sounds good to me. I'm assuming that the addition of these targets
> won't introduce significant amounts of time to the build (i.e. the delta will
be
> < ~5min)

yep, I had compiled them locally and they were all pretty quick (a few minutes
total)