Issue 648823004: DevTools: [SSP] fix memory leak through settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 648823004: DevTools: [SSP] fix memory leak through settings (Closed)

Created:
6 years, 2 months ago by lushnikov

Modified:
6 years, 2 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [SSP] fix memory leak through settings The patch fixes two memory leaks happenning through showInheritedStyle setting. BUG=397228 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184054

Patch Set 1 #

Patch Set 2 : add guards to prevent NPE #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -13 lines)			Patch
	M	Source/devtools/front_end/elements/StylesSidebarPane.js	View	1	4 chunks	+31 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648823004/20001

6 years, 2 months ago (2014-10-21 07:44:47 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 08:32:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 184054

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages