content/browser/loader/upload_data_stream_builder.cc - Issue 648813002: PlzNavigate: Add first version of NavigationURLLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/upload_data_stream_builder.cc

Issue 648813002: PlzNavigate: Add first version of NavigationURLLoader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plz-navigate-prepare

Patch Set: rebase, rework Core ownership story Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/navigation_url_loader_impl.cc ('K') | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/upload_data_stream_builder.cc

diff --git a/content/browser/loader/upload_data_stream_builder.cc b/content/browser/loader/upload_data_stream_builder.cc

index 6419ead79631a1d9ccb3919f671be5200a5f9c5a..2151c59e7d2fd8dfd976cf4f6ef2e21995c7767c 100644

--- a/content/browser/loader/upload_data_stream_builder.cc

+++ b/content/browser/loader/upload_data_stream_builder.cc

@@ -115,6 +115,9 @@ scoped_ptr<net::UploadDataStream> UploadDataStreamBuilder::Build(

new FileElementReader(body, file_task_runner, element));

break;

case ResourceRequestBody::Element::TYPE_FILE_FILESYSTEM:

+ // If |body| contains any filesystem URLs, the caller should have

+ // supplied a FileSystemContext.

+ CHECK(file_system_context);

mmenke 2014/10/22 15:32:59 Any reason for this not to just be a DCHECK?

davidben 2014/10/22 20:58:04 Dug up the long comment here: https://codereview.c

element_readers.push_back(

new content::UploadFileSystemFileElementReader(

file_system_context,