Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: content/browser/loader/navigation_url_loader_core.cc

Issue 648813002: PlzNavigate: Add first version of NavigationURLLoader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plz-navigate-prepare
Patch Set: rebase, rework Core ownership story Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_url_loader_core.cc
diff --git a/content/browser/loader/navigation_url_loader_core.cc b/content/browser/loader/navigation_url_loader_core.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ec0c99b91b731029f0f07edf68a244200d9afb59
--- /dev/null
+++ b/content/browser/loader/navigation_url_loader_core.cc
@@ -0,0 +1,91 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/loader/navigation_url_loader_core.h"
+
+#include "base/bind.h"
+#include "base/location.h"
+#include "content/browser/frame_host/navigation_request_info.h"
+#include "content/browser/loader/navigation_resource_handler.h"
+#include "content/browser/loader/resource_dispatcher_host_impl.h"
+#include "content/common/navigation_params.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/stream_handle.h"
+#include "content/public/common/resource_response.h"
+#include "net/base/net_errors.h"
+#include "net/url_request/redirect_info.h"
+
+namespace content {
+
+NavigationURLLoaderCore::NavigationURLLoaderCore(
+ const base::WeakPtr<NavigationURLLoaderImpl>& loader)
+ : loader_(loader),
+ resource_handler_(nullptr) {
+}
+
+NavigationURLLoaderCore::~NavigationURLLoaderCore() {
+ if (resource_handler_) {
+ resource_handler_->Cancel();
mmenke 2014/10/22 15:32:58 Not a real issue, but just for my edification...Th
davidben 2014/10/22 20:58:04 Well, there isn't a WeakPtr on this end. The Cance
+ resource_handler_ = nullptr;
mmenke 2014/10/22 15:32:58 NULLing out resource_handler_ doesn't seem to get
davidben 2014/10/22 20:58:04 Done.
+ }
+}
+
+void NavigationURLLoaderCore::Start(
+ ResourceContext* resource_context,
+ int64 frame_tree_node_id,
+ const CommonNavigationParams& common_params,
+ scoped_ptr<NavigationRequestInfo> request_info,
+ ResourceRequestBody* request_body) {
+ ResourceDispatcherHostImpl::Get()->BeginNavigationRequest(
+ resource_context, frame_tree_node_id,
+ common_params, *request_info, request_body,
+ this);
+}
+
+void NavigationURLLoaderCore::FollowRedirect() {
+ if (resource_handler_)
+ resource_handler_->FollowRedirect();
+}
+
+
+void NavigationURLLoaderCore::NotifyRequestRedirected(
+ const net::RedirectInfo& redirect_info,
+ ResourceResponse* response) {
+ // Make a copy of the ResourceResponse before it is passed to another thread.
+ //
+ // TODO(davidben): This copy could be avoided if ResourceResponse weren't
+ // reference counted and the loader stack passed unique ownership of the
+ // response. https://crbug.com/416050
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&NavigationURLLoaderImpl::NotifyRequestRedirected, loader_,
+ redirect_info, response->DeepCopy()));
+}
+
+void NavigationURLLoaderCore::NotifyResponseStarted(
+ ResourceResponse* response,
+ scoped_ptr<StreamHandle> body) {
+ // If, by the time the task reaches the UI thread, |loader_| has already been
+ // destroyed, NotifyResponseStarted will not run. |body| will be destructed
+ // and the request released at that point.
+
+ // Make a copy of the ResourceResponse before it is passed to another thread.
+ //
+ // TODO(davidben): This copy could be avoided if ResourceResponse weren't
+ // reference counted and the loader stack passed unique ownership of the
+ // response. https://crbug.com/416050
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&NavigationURLLoaderImpl::NotifyResponseStarted, loader_,
+ response->DeepCopy(), base::Passed(&body)));
+}
+
+void NavigationURLLoaderCore::NotifyRequestFailed(int net_error) {
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&NavigationURLLoaderImpl::NotifyRequestFailed, loader_,
+ net_error));
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698