PlzNavigate: Add first version of NavigationURLLoader.

content/public/common/resource_response.cc

Index: content/public/common/resource_response.cc
diff --git a/content/public/common/resource_response.cc b/content/public/common/resource_response.cc
new file mode 100644
index 0000000000000000000000000000000000000000..41e7be6f65b43ce712e6547bc9684935dcdff473
--- /dev/null
+++ b/content/public/common/resource_response.cc
@@ -0,0 +1,51 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/public/common/resource_response.h"
+
+#include "net/http/http_response_headers.h"
+
+namespace content {
+
+scoped_refptr<ResourceResponse> ResourceResponse::DeepCopy() const {
+  scoped_refptr<ResourceResponse> new_response(new ResourceResponse);
+  new_response->head.request_time = head.request_time;
+  new_response->head.response_time = head.response_time;
+  if (head.headers.get()) {
+    new_response->head.headers =
+        new net::HttpResponseHeaders(head.headers->raw_headers());
+  }
+  new_response->head.mime_type = head.mime_type;
+  new_response->head.charset = head.charset;
+  new_response->head.security_info = head.security_info;
+  new_response->head.content_length = head.content_length;
+  new_response->head.encoded_data_length = head.encoded_data_length;
+  new_response->head.appcache_id = head.appcache_id;
+  new_response->head.appcache_manifest_url = head.appcache_manifest_url;
+  new_response->head.load_timing = head.load_timing;
+  if (head.devtools_info.get()) {
+    new_response->head.devtools_info = head.devtools_info->DeepCopy();
+  }
+  new_response->head.download_file_path = head.download_file_path;
+  new_response->head.was_fetched_via_spdy = head.was_fetched_via_spdy;
+  new_response->head.was_npn_negotiated = head.was_npn_negotiated;
+  new_response->head.was_alternate_protocol_available =
+      new_response->head.was_alternate_protocol_available;
+  new_response->head.connection_info = head.connection_info;
+  new_response->head.was_fetched_via_proxy = head.was_fetched_via_proxy;
+  new_response->head.npn_negotiated_protocol = head.npn_negotiated_protocol;
+  new_response->head.socket_address = head.socket_address;
+  new_response->head.was_fetched_via_service_worker =
+      head.was_fetched_via_service_worker;
+  new_response->head.original_url_via_service_worker =
+      head.original_url_via_service_worker;
+  new_response->head.service_worker_fetch_start =
+      head.service_worker_fetch_start;
+  new_response->head.service_worker_fetch_ready =
+      head.service_worker_fetch_ready;
+  new_response->head.service_worker_fetch_end = head.service_worker_fetch_end;
+  return new_response;

[nasko, 2014/10/20 13:52:18]

I counted a few more fields exist than copied here. will correlate later to see
which are missing, but this indicates a problem to me - easy to forget to add a
field here when added to the struct.

[davidben, 2014/10/22 01:32:37]

Probably a rebase. Added was_fallback_required_by_service_worker which seems to
have been the new one. But, yeah, I agree. I don't really have a good answer
though. We can almost pass unique ownership down but for the
BufferedResourceHandler dispatch. I'd like that dispatch to move to the
navigation layer, but with or without that, we need to be able to plumb a copy
of the ResourceResponse down to DevTools.

This structure is basically copyable anyway via IPC. It's just not copyable
in-memory, which is kind of bizarre.

If we could instead ensure that the ResourceResponse is not modified past a
certain point, that would be another option. It's currently modified all over
the place though. BufferedResourceHandler makes some modifications.
AsyncResourceHandler staples DevTools info. ChromeResourceDispatcherHostDelegate
strips some headers in some place. I'm sure ServiceWorker makes modifications
too. But I'd be uneasy unless we could make the compiler enforce whatever
immutability we decide on.

+}
+
+}  // namespace content